On Sat, Apr 26, 2014 at 1:49 AM, Kurt Roeckx <[email protected]> wrote: > My current understanding of things is I think that second > "p = p->right" is wrong. (The tests actually pass if I > remove it.) This second one is also not present in the > _asn1_ordering_set() function. I see no good reason why > we need to move one more entry right.
It looks like a copy paste error, and given that it is not present in the _asn1_ordering_set() it is most likely one. > But I think that the return ASN1_VALUE_NOT_FOUND is > also wrong. If the set contains 0 or 1 entries there > is nothing to sort and we can just return. Looks reasonable. > That would give the following diff that works for me: I've combined that to your previous patch and committed it. I've also added the test that triggered the issue in libtasn1. regards, Nikos
