Hi all, I'm running into various changes when using VisualGST and I have started fixing some easy ones...
1.) Reduce copies of the MIT License. Move it into VisualGST and be done with it. 2.) Change GTK.GtkAboutDialog new to use GTK.Gtk showAboutDialog. This has the benefit that the "response" of the GtkDialog is handled by default and that the close button is starting to work. It is also fixing some inconsistencies with run vs. showModal... 3.) Fix GtkAssistant's help entry 4.) Fix the creation of the "Smallzilla"... my main issues with VisualGST so far are: *) the debugger should not show its activation in the backtrace *) 'Accept' does not seem to work in various contexts *) The SUnit viewer should filter empty namespaces and classes *) stuff i forgot.
>From abd817bcef6fcfcad7b3f4a6a4d91f9bc8b1b38b Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther <[email protected]> Date: Mon, 26 Apr 2010 21:29:02 +0800 Subject: [PATCH 2/5] Reduce copies of the MIT License text for the About Dialog 2010-04-24 Holger Hans Peter Freyther <[email protected]> * kernel/PkgLoader.st: Print the file name of the package that will be loaded. Add Package>>describe and StarPackage>>describe to describe the origin. --- packages/visualgst/ChangeLog | 7 +++++++ packages/visualgst/GtkAssistant.st | 17 +---------------- packages/visualgst/GtkClassBrowser.st | 17 +---------------- packages/visualgst/GtkWebBrowser.st | 17 +---------------- packages/visualgst/VisualGST.st | 19 +++++++++++++------ 5 files changed, 23 insertions(+), 54 deletions(-) diff --git a/packages/visualgst/ChangeLog b/packages/visualgst/ChangeLog index 418a024..cb13caf 100644 --- a/packages/visualgst/ChangeLog +++ b/packages/visualgst/ChangeLog @@ -1,3 +1,10 @@ +2010-04-26 Holger Hans Peter Freyther <[email protected]> + + * Debugger/GtkDebugger.st, GtkAssistant.st, GtkClassBrowser.st, + GtkWebBrowser.st, Implementors/GtkImplementor.st, SUnit/GtkSUnit.st, + Senders/GtkSender.st, VisualGST.st: Move the MIT License text + into VisualGST.st and call VisualGST license to get the text. + 2010-04-19 Paolo Bonzini <[email protected]> * GtkTranscriptWidget: Convert what is #show:-ed to a string. diff --git a/packages/visualgst/GtkAssistant.st b/packages/visualgst/GtkAssistant.st index 04a82bd..c34abd4 100644 --- a/packages/visualgst/GtkAssistant.st +++ b/packages/visualgst/GtkAssistant.st @@ -12,22 +12,7 @@ GtkMainWindow subclass: GtkAssistant [ (GTK.GtkAboutDialog new) setVersion: '0.2.0'; - setLicense: 'Permission is hereby granted, free of charge, to any person obtaining -a copy of this software and associated documentation files (the "Software"), -to deal in the Software without restriction, including without limitation -the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or -sell copies of the Software, and to permit persons to whom the Software is furnished -to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in -all copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, -INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A -PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR -COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN -AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH -THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.'; + setLicense: VisualGST license; setWebsite: 'http://le site du gnu'; setComments: 'This is a GTK+ wrapper for GNU Smalltalk.'; "setAuthors: {'Gwenael Casaccio'. 'Nicolas Petton'};" diff --git a/packages/visualgst/GtkClassBrowser.st b/packages/visualgst/GtkClassBrowser.st index b7d87a1..204b4c1 100644 --- a/packages/visualgst/GtkClassBrowser.st +++ b/packages/visualgst/GtkClassBrowser.st @@ -12,22 +12,7 @@ GtkMainWindow subclass: GtkClassBrowser [ (GTK.GtkAboutDialog new) setVersion: VisualGST version; - setLicense: 'Permission is hereby granted, free of charge, to any person obtaining -a copy of this software and associated documentation files (the "Software"), -to deal in the Software without restriction, including without limitation -the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or -sell copies of the Software, and to permit persons to whom the Software is furnished -to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in -all copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, -INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A -PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR -COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN -AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH -THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.'; + setLicense: VisualGST license; setWebsite: VisualGST website; setComments: 'This is a system browser for GNU Smalltalk.'; "setAuthors: {'Gwenael Casaccio'. 'Nicolas Petton'};" diff --git a/packages/visualgst/GtkWebBrowser.st b/packages/visualgst/GtkWebBrowser.st index bb09c60..082d243 100644 --- a/packages/visualgst/GtkWebBrowser.st +++ b/packages/visualgst/GtkWebBrowser.st @@ -19,22 +19,7 @@ GtkMainWindow subclass: GtkWebBrowser [ (GTK.GtkAboutDialog new) setVersion: VisualGST version; - setLicense: 'Permission is hereby granted, free of charge, to any person obtaining -a copy of this software and associated documentation files (the "Software"), -to deal in the Software without restriction, including without limitation -the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or -sell copies of the Software, and to permit persons to whom the Software is furnished -to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in -all copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, -INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A -PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR -COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN -AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH -THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.'; + setLicense: VisualGST license; setWebsite: 'http://le site du gnu'; setComments: 'This is a GTK+ wrapper for GNU Smalltalk.'; "setAuthors: {'Gwenael Casaccio'. 'Nicolas Petton'};" diff --git a/packages/visualgst/VisualGST.st b/packages/visualgst/VisualGST.st index 10872a9..38b0a3a 100644 --- a/packages/visualgst/VisualGST.st +++ b/packages/visualgst/VisualGST.st @@ -84,12 +84,11 @@ GtkMainWindow subclass: VisualGST [ compileError := aWorkspace ] - aboutLauncher [ - <category: 'help events'> + VisualGST class >> license [ + <category: 'accessing'> - (GTK.GtkAboutDialog new) - setVersion: self class version; - setLicense: 'Permission is hereby granted, free of charge, to any person obtaining + ^ +'Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or @@ -104,7 +103,15 @@ INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH -THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.'; +THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.' + ] + + aboutLauncher [ + <category: 'help events'> + + (GTK.GtkAboutDialog new) + setVersion: self class version; + setLicense: self class license; setWebsite: self class website; setComments: 'This is a GTK+ wrapper for GNU Smalltalk.'; "setAuthors: {'Gwenael Casaccio'. 'Nicolas Petton'. nil};" -- 1.7.0.1
>From 34a923671c8dcbdf537941443f5138b8dec6845f Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther <[email protected]> Date: Tue, 27 Apr 2010 01:15:35 +0800 Subject: [PATCH 3/5] VisualGST: Close button does not close the about dialog. 2010-04-27 Holger Hans Peter Freyther <[email protected]> * Debugger/GtkDebugger.st, GtkAssistant.st, GtkClassBrowser.st, GtkMainWindow.st, GtkWebBrowser.st, Implementors/GtkImplementor.st, SUnit/GtkSUnit.st, Senders/GtkSender.st, VisualGST.st: Move to GTK.Gtk>>showAboutDialog for showing the about dialog. This has the benefit that the 'response' signal is handled automatically. --- packages/visualgst/ChangeLog | 8 ++++++ packages/visualgst/Debugger/GtkDebugger.st | 28 ++++---------------- packages/visualgst/GtkAssistant.st | 13 ++++----- packages/visualgst/GtkClassBrowser.st | 13 ++++----- packages/visualgst/GtkMainWindow.st | 13 ++++----- packages/visualgst/GtkWebBrowser.st | 13 ++++----- packages/visualgst/Implementors/GtkImplementor.st | 28 ++++---------------- packages/visualgst/SUnit/GtkSUnit.st | 29 +++++---------------- packages/visualgst/Senders/GtkSender.st | 28 ++++---------------- packages/visualgst/VisualGST.st | 13 ++++----- 10 files changed, 63 insertions(+), 123 deletions(-) diff --git a/packages/visualgst/ChangeLog b/packages/visualgst/ChangeLog index cb13caf..291d6db 100644 --- a/packages/visualgst/ChangeLog +++ b/packages/visualgst/ChangeLog @@ -1,3 +1,11 @@ +2010-04-27 Holger Hans Peter Freyther <[email protected]> + + * Debugger/GtkDebugger.st, GtkAssistant.st, GtkClassBrowser.st, + GtkMainWindow.st, GtkWebBrowser.st, Implementors/GtkImplementor.st, + SUnit/GtkSUnit.st, Senders/GtkSender.st, VisualGST.st: Move to + GTK.Gtk>>showAboutDialog for showing the about dialog. This has the + benefit that the 'response' signal is handled automatically. + 2010-04-26 Holger Hans Peter Freyther <[email protected]> * Debugger/GtkDebugger.st, GtkAssistant.st, GtkClassBrowser.st, diff --git a/packages/visualgst/Debugger/GtkDebugger.st b/packages/visualgst/Debugger/GtkDebugger.st index d4e4a34..5721fec 100644 --- a/packages/visualgst/Debugger/GtkDebugger.st +++ b/packages/visualgst/Debugger/GtkDebugger.st @@ -40,29 +40,13 @@ GtkMainWindow subclass: GtkDebugger [ aboutDebugger [ <category: 'help events'> - (GTK.GtkAboutDialog new) - setVersion: self class version; - setLicense: 'Permission is hereby granted, free of charge, to any person obtaining -a copy of this software and associated documentation files (the "Software"), -to deal in the Software without restriction, including without limitation -the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or -sell copies of the Software, and to permit persons to whom the Software is furnished -to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in -all copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, -INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A -PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR -COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN -AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH -THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.'; - setWebsite: self class website; - setComments: 'This is a GTK+ wrapper for GNU Smalltalk.'; + GTK.Gtk showAboutDialog: nil varargs: { + 'version' . self class version. + 'license' . VisualGST license. + 'website' . self class website. + 'comments'. 'This is a GTK+ wrapper for GNU Smalltalk.'. + 'program-name' . 'VisualGST Debugger' . nil } "setAuthors: {'Gwenael Casaccio'. 'Nicolas Petton'. nil};" - setProgramName: 'VisualGST Debugger'; - showModalDestroy ] initialize [ diff --git a/packages/visualgst/GtkAssistant.st b/packages/visualgst/GtkAssistant.st index c34abd4..cdcae2c 100644 --- a/packages/visualgst/GtkAssistant.st +++ b/packages/visualgst/GtkAssistant.st @@ -10,14 +10,13 @@ GtkMainWindow subclass: GtkAssistant [ aboutBrowser [ <category: 'help events'> - (GTK.GtkAboutDialog new) - setVersion: '0.2.0'; - setLicense: VisualGST license; - setWebsite: 'http://le site du gnu'; - setComments: 'This is a GTK+ wrapper for GNU Smalltalk.'; + GTK.Gtk showAboutDialog: nil varargs: { + 'version' . '0.2.0'. + 'license' . VisualGST license. + 'website' . 'http://le site du gnu'. + 'comments' . 'This is a GTK+ wrapper for GNU Smalltalk.'. + 'program-name' . 'GNU Smalltalk Launcher' . nil } "setAuthors: {'Gwenael Casaccio'. 'Nicolas Petton'};" - setProgramName: 'GNU Smalltalk Launcher'; - showModalDestroy ] initialize [ diff --git a/packages/visualgst/GtkClassBrowser.st b/packages/visualgst/GtkClassBrowser.st index 204b4c1..a8e61a4 100644 --- a/packages/visualgst/GtkClassBrowser.st +++ b/packages/visualgst/GtkClassBrowser.st @@ -10,14 +10,13 @@ GtkMainWindow subclass: GtkClassBrowser [ aboutBrowser [ <category: 'events'> - (GTK.GtkAboutDialog new) - setVersion: VisualGST version; - setLicense: VisualGST license; - setWebsite: VisualGST website; - setComments: 'This is a system browser for GNU Smalltalk.'; + GTK.Gtk showAboutDialog: nil varargs: { + 'version' . VisualGST version. + 'license' . VisualGST license. + 'website' . VisualGST website. + 'comments' . 'This is a system browser for GNU Smalltalk.'. + 'program-name' . 'GNU Smalltalk Browser' . nil } "setAuthors: {'Gwenael Casaccio'. 'Nicolas Petton'};" - setProgramName: 'GNU Smalltalk Browser'; - showModalDestroy ] browser [ diff --git a/packages/visualgst/GtkMainWindow.st b/packages/visualgst/GtkMainWindow.st index 01bea93..0306da8 100644 --- a/packages/visualgst/GtkMainWindow.st +++ b/packages/visualgst/GtkMainWindow.st @@ -97,10 +97,10 @@ Smalltalk.Object subclass: GtkMainWindow [ aboutGst [ <category: 'events'> - (GTK.GtkAboutDialog new) - setProgramName: 'GNU Smalltalk'; - setVersion: (Smalltalk version =~ 'version (.*)' at: 1); - setLicense: 'GNU Smalltalk is free software; you can redistribute it and/or modify it + GTK.Gtk showAboutDialog: nil varargs: { + 'program-name' . 'GNU Smalltalk' . + 'version' . (Smalltalk version =~ 'version (.*)' at: 1) . + 'license' . 'GNU Smalltalk is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2, or (at your option) any later version. @@ -114,9 +114,8 @@ GNU Smalltalk; see the file COPYING. If not, write to the Free Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. Please consult the GNU Smalltalk source code for additional permissions -that are specific to this version of GNU Smalltalk.'; - setWebsite: 'http://smalltalk.gnu.org/'; - showModalDestroy +that are specific to this version of GNU Smalltalk.' . + 'website' . 'http://smalltalk.gnu.org/' . nil } ] close [ diff --git a/packages/visualgst/GtkWebBrowser.st b/packages/visualgst/GtkWebBrowser.st index 082d243..3c77c7c 100644 --- a/packages/visualgst/GtkWebBrowser.st +++ b/packages/visualgst/GtkWebBrowser.st @@ -17,14 +17,13 @@ GtkMainWindow subclass: GtkWebBrowser [ aboutBrowser [ <category: 'help events'> - (GTK.GtkAboutDialog new) - setVersion: VisualGST version; - setLicense: VisualGST license; - setWebsite: 'http://le site du gnu'; - setComments: 'This is a GTK+ wrapper for GNU Smalltalk.'; + GTK.Gtk showAboutDialog: nil varargs: { + 'version' . VisualGST version. + 'license' . VisualGST license. + 'website' . 'http://le site du gnu'. + 'comments' . 'This is a GTK+ wrapper for GNU Smalltalk.'. + 'rogram-name' . 'GNU Smalltalk Launcher' . nil } "setAuthors: {'Gwenael Casaccio'. 'Nicolas Petton'};" - setProgramName: 'GNU Smalltalk Launcher'; - showModalDestroy ] initialize [ diff --git a/packages/visualgst/Implementors/GtkImplementor.st b/packages/visualgst/Implementors/GtkImplementor.st index 6f2c849..9ccc967 100644 --- a/packages/visualgst/Implementors/GtkImplementor.st +++ b/packages/visualgst/Implementors/GtkImplementor.st @@ -271,29 +271,13 @@ GtkMainWindow subclass: GtkImplementor [ aboutImplementor [ <category: 'events'> - (GTK.GtkAboutDialog new) - setVersion: VisualGST version; - setLicense: 'Permission is hereby granted, free of charge, to any person obtaining -a copy of this software and associated documentation files (the "Software"), -to deal in the Software without restriction, including without limitation -the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or -sell copies of the Software, and to permit persons to whom the Software is furnished -to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in -all copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, -INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A -PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR -COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN -AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH -THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.'; - setWebsite: VisualGST website; - setComments: 'This is a GTK+ wrapper for GNU Smalltalk.'; + GTK.Gtk showAboutDialog: nil varargs: { + 'version' . VisualGST version. + 'license' . VisualGST license. + 'website' . VisualGST website. + 'comments' . 'This is a GTK+ wrapper for GNU Smalltalk.'. + 'program-name' . 'GNU Smalltalk Implementor' . nil } "setAuthors: {'Gwenael Casaccio'. 'Nicolas Petton'};" - setProgramName: 'GNU Smalltalk Implementor'; - run ] elementSelected [ diff --git a/packages/visualgst/SUnit/GtkSUnit.st b/packages/visualgst/SUnit/GtkSUnit.st index 92f3c83..d83e835 100644 --- a/packages/visualgst/SUnit/GtkSUnit.st +++ b/packages/visualgst/SUnit/GtkSUnit.st @@ -234,29 +234,14 @@ GtkMainWindow subclass: GtkSUnit [ aboutSUnit [ <category: 'events'> - (GTK.GtkAboutDialog new) - setVersion: VisualGST version; - setLicense: 'Permission is hereby granted, free of charge, to any person obtaining -a copy of this software and associated documentation files (the "Software"), -to deal in the Software without restriction, including without limitation -the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or -sell copies of the Software, and to permit persons to whom the Software is furnished -to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in -all copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, -INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A -PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR -COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN -AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH -THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.'; - setWebsite: VisualGST website; - setComments: 'This is a GTK+ wrapper for GNU Smalltalk.'; + GTK.Gtk showAboutDialog: nil + varargs: { + 'version' . VisualGST version. + 'license' . VisualGST license. + 'website' . VisualGST website. + 'comments' . 'This is a GTK+ wrapper for GNU Smalltalk.'. + 'program-name' . 'GNU Smalltalk SUnit' . nil} "setAuthors: {'Gwenael Casaccio'. 'Nicolas Petton'};" - setProgramName: 'GNU Smalltalk SUnit'; - run ] buildNamespaceWidget [ diff --git a/packages/visualgst/Senders/GtkSender.st b/packages/visualgst/Senders/GtkSender.st index 7abcd8d..eebfd2c 100644 --- a/packages/visualgst/Senders/GtkSender.st +++ b/packages/visualgst/Senders/GtkSender.st @@ -303,29 +303,13 @@ GtkMainWindow subclass: GtkSender [ aboutSender [ <category: 'events'> - (GTK.GtkAboutDialog new) - setVersion: VisualGST version; - setLicense: 'Permission is hereby granted, free of charge, to any person obtaining -a copy of this software and associated documentation files (the "Software"), -to deal in the Software without restriction, including without limitation -the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or -sell copies of the Software, and to permit persons to whom the Software is furnished -to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in -all copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, -INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A -PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR -COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN -AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH -THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.'; - setWebsite: VisualGST website; - setComments: 'This is a GTK+ wrapper for GNU Smalltalk.'; + GTK.Gtk showAboutDialog: nil varargs: { + 'version' . VisualGST version. + 'license' . VisualGST license. + 'website' . VisualGST website. + 'comments' . 'This is a GTK+ wrapper for GNU Smalltalk.'. + 'program-name' . 'GNU Smalltalk Implementor' . nil } "setAuthors: {'Gwenael Casaccio'. 'Nicolas Petton'};" - setProgramName: 'GNU Smalltalk Sender'; - run ] findInMethod: anObject [ diff --git a/packages/visualgst/VisualGST.st b/packages/visualgst/VisualGST.st index 38b0a3a..e7a8ca1 100644 --- a/packages/visualgst/VisualGST.st +++ b/packages/visualgst/VisualGST.st @@ -109,14 +109,13 @@ THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.' aboutLauncher [ <category: 'help events'> - (GTK.GtkAboutDialog new) - setVersion: self class version; - setLicense: self class license; - setWebsite: self class website; - setComments: 'This is a GTK+ wrapper for GNU Smalltalk.'; + GTK.Gtk showAboutDialog: nil varargs: { + 'version' . self class version. + 'license' . self class license. + 'website' . self class website. + 'comments' . 'This is a GTK+ wrapper for GNU Smalltalk.'. + 'program-name' . 'VisualGST' . nil } "setAuthors: {'Gwenael Casaccio'. 'Nicolas Petton'. nil};" - setProgramName: 'VisualGST'; - showModalDestroy ] browser [ -- 1.7.0.1
>From fa33bf5da8060fc0223ed08aa0c03d6a473662ce Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther <[email protected]> Date: Tue, 27 Apr 2010 13:36:06 +0800 Subject: [PATCH 4/5] VisualGST: Fix the help inside the GtkAssistant. The "About Assistant" menu item was connected to the aboutAssistant selector but it did not exist, instead there was an aboutBrowser. I decided to rename it. 2010-04-27 Holger Hans Peter Freyther <[email protected]> * GtkAssistant.st: Rename selector from #aboutBrowser to #aboutAssistant. --- packages/visualgst/ChangeLog | 7 ++++++- packages/visualgst/GtkAssistant.st | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/visualgst/ChangeLog b/packages/visualgst/ChangeLog index 291d6db..d747aa7 100644 --- a/packages/visualgst/ChangeLog +++ b/packages/visualgst/ChangeLog @@ -1,6 +1,11 @@ 2010-04-27 Holger Hans Peter Freyther <[email protected]> - * Debugger/GtkDebugger.st, GtkAssistant.st, GtkClassBrowser.st, + * GtkAssistant.st: Rename selector from #aboutBrowser to + #aboutAssistant. + +2010-04-27 Holger Hans Peter Freyther <[email protected]> + + * Debugger/GtkDebugger.st, GtkAssistant.st, GtkClassBrowser.st, GtkMainWindow.st, GtkWebBrowser.st, Implementors/GtkImplementor.st, SUnit/GtkSUnit.st, Senders/GtkSender.st, VisualGST.st: Move to GTK.Gtk>>showAboutDialog for showing the about dialog. This has the diff --git a/packages/visualgst/GtkAssistant.st b/packages/visualgst/GtkAssistant.st index cdcae2c..34f9645 100644 --- a/packages/visualgst/GtkAssistant.st +++ b/packages/visualgst/GtkAssistant.st @@ -7,7 +7,7 @@ GtkMainWindow subclass: GtkAssistant [ ^ self openSized: 4...@375 ] - aboutBrowser [ + aboutAssistant [ <category: 'help events'> GTK.Gtk showAboutDialog: nil varargs: { -- 1.7.0.1
>From 8f02dba0d33cc84df5583057374d9584c2e3f477 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther <[email protected]> Date: Tue, 27 Apr 2010 13:43:38 +0800 Subject: [PATCH 5/5] VisualGST: Fix creating the Smallzilla Tool 2010-04-27 Holger Hans Peter Freyther <[email protected]> * GtkWebBrowser.st: Fix #createToolbar. --- packages/visualgst/ChangeLog | 4 ++++ packages/visualgst/GtkWebBrowser.st | 2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/packages/visualgst/ChangeLog b/packages/visualgst/ChangeLog index d747aa7..636fb95 100644 --- a/packages/visualgst/ChangeLog +++ b/packages/visualgst/ChangeLog @@ -1,5 +1,9 @@ 2010-04-27 Holger Hans Peter Freyther <[email protected]> + * GtkWebBrowser.st: Fix #createToolbar. + +2010-04-27 Holger Hans Peter Freyther <[email protected]> + * GtkAssistant.st: Rename selector from #aboutBrowser to #aboutAssistant. diff --git a/packages/visualgst/GtkWebBrowser.st b/packages/visualgst/GtkWebBrowser.st index 3c77c7c..d7bc966 100644 --- a/packages/visualgst/GtkWebBrowser.st +++ b/packages/visualgst/GtkWebBrowser.st @@ -116,7 +116,7 @@ GtkMainWindow subclass: GtkWebBrowser [ appendToolItem: (GTK.GtkToolButton newFromStock: 'gtk-copy'); appendToolItem: (GTK.GtkToolButton newFromStock: 'gtk-paste'); appendSeparator; - appendToolItem: (GTK.GtkToolButton newFromStock: 'gtk-execute' label: 'Do It') + appendToolItem: (GTK.GtkToolButton newFromStock: 'gtk-execute' label: 'Do It'); appendToolItem: (GTK.GtkToolButton newFromStock: 'gtk-convert' label: 'Inspect It') ] -- 1.7.0.1
_______________________________________________ help-smalltalk mailing list [email protected] http://lists.gnu.org/mailman/listinfo/help-smalltalk
