Hi Paolo, right now executing gst-remote --server 127.0.0.1 ends up with an exception on start. So the gst-remote server runs but is not listening anywhere (which should be addressed separately, should it?).
So here the question. Should we resolve the address in Remote.st or should we resolve it inside the ServerSocket port:bindTo: like we do for many/all the other sockets? holger
>From ccff2d6b0fccb151fbdeeb79be149ddf276791a3 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther <[email protected]> Date: Mon, 30 May 2011 00:09:00 +0200 Subject: [PATCH] scripts/Remote.st: Allow to specify the hostname for the bind Allow to bind the server to a specific address. The ServerSocket will not attempt to resolve the string to an address. Do this before. 2011-05-30 Holger Hans Peter Freyther <[email protected]> * scripts/Remote.st: Resolve the hostname to an address to be used by Sockets.ServerSocket>>#port:bindTo:. --- ChangeLog | 5 +++++ scripts/Remote.st | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index d86e8c3..cef29ac 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2011-05-30 Holger Hans Peter Freyther <[email protected]> + + * scripts/Remote.st: Resolve the hostname to an address to be + used by Sockets.ServerSocket>>#port:bindTo:. + 2011-05-19 Paolo Bonzini <[email protected]> * kernel/SysExcept.st: Wrap modifications to #'__terminate' with diff --git a/scripts/Remote.st b/scripts/Remote.st index 10f228d..ec65de4 100644 --- a/scripts/Remote.st +++ b/scripts/Remote.st @@ -182,10 +182,10 @@ available in the PATH of the remote machine. opt isNil ifTrue: [ host isNil ifFalse: [ self error: 'multiple hosts are invalid' ]. (arg includes: $@) - ifFalse: [ host := arg ] + ifFalse: [ host := TCP.SocketAddress byName: arg ] ifTrue: [ login isNil ifFalse: [ self error: 'multiple logins are invalid' ]. - login := arg copyUpTo: $@. + login := TCP.SocketAddress byName: (arg copyUpTo: $@). host := arg copyAfter: $@ ] ]. ] -- 1.7.4.1
_______________________________________________ help-smalltalk mailing list [email protected] https://lists.gnu.org/mailman/listinfo/help-smalltalk
