On 28/05/2013 20:33, Holger Hans Peter Freyther wrote:
On Tue, May 28, 2013 at 11:16:15AM +0200, Gwenaël Casaccio wrote:
Hi,
it fixes an old bug.
Looks great! Could you please describe in your commit message on how
it could be re-produced? In terms of unit testing, by default we can
not assume to have a GTK/X11 connection but it would be nice to test
behavior anyway. How feasible is this?
thanks
holger
The new version
Gwen
>From 1668b7e34a6baf3b5c6011312c4c314a292605df Mon Sep 17 00:00:00 2001
From: Gwenael Casaccio <[email protected]>
Date: Fri, 31 May 2013 10:24:36 +0200
Subject: [PATCH] Do not display metaclassesin hierarchy browse. When you're on
the class browser select Object and show the class hierarchy as a result
you'll see all the metaclasses.
---
packages/visualgst/StBrowser/GtkClassHierarchyWidget.st | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/packages/visualgst/StBrowser/GtkClassHierarchyWidget.st b/packages/visualgst/StBrowser/GtkClassHierarchyWidget.st
index 1b85188..f861d59 100644
--- a/packages/visualgst/StBrowser/GtkClassHierarchyWidget.st
+++ b/packages/visualgst/StBrowser/GtkClassHierarchyWidget.st
@@ -37,7 +37,7 @@ GtkConcreteWidget subclass: GtkClassHierarchyWidget [
classOrMeta: aClass [
<category: 'accessing'>
- classOrMeta := aClass.
+ classOrMeta := aClass asClass.
dic := Dictionary new.
self buildSuperclasses.
model
@@ -56,7 +56,7 @@ GtkConcreteWidget subclass: GtkClassHierarchyWidget [
buildSuperclasses [
| parent |
- parent := self classOrMeta asClass.
+ parent := self classOrMeta.
[ parent isNil ] whileFalse: [
dic at: (parent superclass ifNil: [ #root ]) put: {parent}.
root := parent.
@@ -73,7 +73,7 @@ GtkConcreteWidget subclass: GtkClassHierarchyWidget [
childrenBlock: [ :each |
dic at: each ifAbsent: [ | col |
col := SortedCollection sortBlock: [ :a :b | a asClass name <= b asClass name ].
- col addAll: each subclasses.
+ col addAll: (each subclasses select: [ :behavior | behavior isClass ]).
col ] ];
contentsBlock: [ :each | {each asClass name asString, ' '} ].
^ GTK.GtkScrolledWindow withChild: classesTree
--
1.8.1.2
_______________________________________________
help-smalltalk mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
