On Fri, Jun 07, 2013 at 05:15:15PM +0200, Gwenaël Casaccio wrote:

> -      if (_gst_declare_arguments (method->v_method.selectorExpr) == -1)
> +      if ((argCount = _gst_declare_arguments 
> (method->v_method.selectorExpr)) == -1)

I don't know the GNU style but I find such statements with this kind of
side-effect dangerous.

        argCount = _gst_declare_arguments (method->v_method.selectorExpr);
        if (argCount == -1)
          ....

> +            object->data[0] = _gst_intern_string 
> (args->v_expr.expression->v_list.name);
> +            i = i + 1;

               i += 1; ??


I still need to have a deeper look, but thank you so far.

_______________________________________________
help-smalltalk mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

Reply via email to