On Mon, Dec 16, 2013 at 10:10:56AM +0800, Lee Duhem wrote:
> Hi all,

Hi!

> It looks like Behavior>>allSharedPools is broken:
> 
>     st> Array allSharedPools

> This Dictionary which cannot understand #nameIn: is VMPrimitives. Should it
> also be a BindingDictionary?
> 
> Anyway, the attached patch makes VMPrimitives a BindingDictionary, fixes the
> Behavior>>allSharedPools, and does not introduce any regression error.

Paolo knows this code better than I do but based on the other Pool being
a BindingDictionary and the code using nameIn I would go with your patch.

> BTW, I would like to provide a test case for Behavior>>allSharedPools, but
> I am not sure what to expect.

I think a test that makes sure that no exception is thrown is already progress.


_______________________________________________
help-smalltalk mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

Reply via email to