Hello Maxime,

* Maxime COSTE <[EMAIL PROTECTED]> wrote:
> Here is a patch that add support for libmpcdec in herrie, allowing it to play
> musepack files.
> 
> Tell me if I need to change anything.

Sorry for letting you wait this long - I've been very busy lately at
work/uni lately.

> +    if (!fd->stream) {
> +        fseek(fd->fp, 0, SEEK_END);
> +        data->size = ftell(fd->fp);
> +        fseek(fd->fp, 0, SEEK_SET);
> +    } else
> +        data->size = 0;

Herrie's streaming implementation is very primitive and has no way to
`taste' a stream to match with an audio module. We should actually have
a list of mime types, but I haven't found any time to do this. Maybe the
best thing would be to just return an error when you hit a stream? I
know, it's not very good, but right now it prevents MP3 streams from
being played.

What's your opinion on this matter?

-- 
 Ed Schouten <[EMAIL PROTECTED]>
 WWW: http://80386.nl/

Attachment: pgptUr7tUH7a4.pgp
Description: PGP signature

Reply via email to