Thank you. Great job.
And now I can have some fun with git.

Davide

On Thu, Jun 2, 2011 at 7:26 PM, Sanne Grinovero <sa...@hibernate.org> wrote:
> Hi Davide,
> so, this took me a while as there where a number of problems with the
> annotation processor; thanks to John and Steve for pointing me in the
> right direction.
>
> The main problem was:  http://bugs.sun.com/view_bug.do?bug_id=6512707
> basically we can't have the annotation processor run during compile
> phase, but need to do that in a second phase.
>
> I've pushed my version of your patches on my branch:
> https://github.com/Sanne/hibernate-search/tree/HSEARCH-675
>
> After many experiments including maven-ant-run and maven compiler
> settings, it seems I found a clean strategy using
> org.bsc.maven:maven-processor-plugin.
> I had this discarded initially as it's documentation said it was not
> in central.. but Gustavo pointed out it actually is! great teamwork.
>
> Please note I've been cleaning up the reformatting mess in the pom.xml
> s, now you can see that the changes are straight to the point, with no
> whitespace noise or other unrelated changes. I've appended some of the
> patches you made on top of it, but I'll leave that to you to judge
> which ones where duplicate/redundant and to cleanup your history:
> have fun with git, that's a good excercise :)
>
> thanks again for all the help,
> Sanne
>
> 2011/6/2 Davide D'Alto <daltodav...@gmail.com>:
>> Hi,
>> I'm working on the inclusion of JBoss Logging in HIbernate Search
>> (http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-675).
>>
>> I've included in the pom this two dependencies:
>> ...
>>            <dependency>
>>                <groupId>org.jboss.logging</groupId>
>>                <artifactId>jboss-logging</artifactId>
>>                <version>3.0.0.Beta5</version>
>>            </dependency>
>>            <dependency>
>>                <groupId>org.jboss.logging</groupId>
>>                <artifactId>jboss-logging-processor</artifactId>
>>                <version>1.0.0.Beta5</version>
>>            </dependency>
>> ...
>>
>> But when I run  maven test I have several exceptions during
>> compilation like these:
>> ...
>> [ERROR] 
>> /home/davide/workspaces/contributions/hibernate-search/hibernate-search/src/main/java/org/hibernate/search/annotations/ClassBridge.java:[70,43]
>> incompatible types
>> [ERROR] found   : org.hibernate.search.annotations.TermVector
>> [ERROR] required: org.hibernate.search.annotations.TermVector
>> [ERROR] 
>> /home/davide/workspaces/contributions/hibernate-search/hibernate-search/src/main/java/org/hibernate/search/annotations/ClassBridge.java:[76,24]
>> incompatible types
>> [ERROR] found   : org.hibernate.search.annotations.Boost
>> [ERROR] required: org.hibernate.search.annotations.Boost
>> ...
>>
>> This is the project with the dependecies in the pom:
>> https://github.com/DavideD/hibernate-search/commits/HSEARCH-675
>> Do I need other dependencies?
>>
>> Thanks,
>> Davide
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev@lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
>

_______________________________________________
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Reply via email to