Hi Adam and Felix, There have also been some changes to existing methods. In some cases, the arguments don't seem to be passed correctly.
I don't want to risk breaking things in Hibernate 5, so please answer my questions in the pull request: https://github.com/hibernate/hibernate-orm/pull/1079. . Thanks, Gail On Tue, Sep 15, 2015 at 5:24 AM, Adam Warski <a...@warski.org> wrote: > Hello, > > thanks a lot for taking the time to migrate that PR! > I’m really out-of-touch with the current changes in Hibernate, however > there are no changes to the existing public interface (only method > additions), and if the tests pass, it’s safe to merge. > > There’s definitely a lot of value in having only -to-one relations working > alone, so I think -to-maby support may be safely left for later. > > Adam > > > On 11 Sep 2015, at 20:48, Gail Badner <gbad...@redhat.com> wrote: > > I've created a new pull request for HHH-3555. [1] > > A new pull request was needed because there have been lots of changes in > master since the original pull request [2] was created. > > I would like to get this pushed to master and, if possible, to 5.0 branch. > > There are some questions in the pull request I need answered before moving > forward. > > Could someone familiar with Envers please take a look at [1] when you have > a chance. > > Thanks! > Gail > > [1] https://github.com/hibernate/hibernate-orm/pull/1079 > [2] https://github.com/hibernate/hibernate-orm/pull/847 > > > -- > Adam Warski > > http://twitter.com/#!/adamwarski > http://www.softwaremill.com > http://www.warski.org > > _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev