Hi all (and especially Gunnar), I dug a bit in your ElasticSearch work today as I wanted to give a try to the facet implementation and I was wondering if maybe we should use the ElasticSearch DSL to build the queries instead of building raw JSON strings.
I experimented here: https://github.com/gsmet/hibernate-search/commit/18737f720a1200b125adf2bb0465b52d5d2b3ca3 I think the code is a bit clearer now. I haven't changed all the queries in the tests so I kept the fromJson method in ElasticSearchQueries but I think we should remove it and rely on the DSL: I'll wait for your opinion as you might have had a very good reason to not use the DSL. One of the challenges waiting for us will be to transform the Lucene Filters into proper Elastic Search queries. -- Guillaume _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
