Nothing major, but still this got me wondering: - why the parent pom "hibernate-validator-relocation" ? - why the profile switch? do you plan to omit these artifacts for - say - nightly builds and local testing of other projects depending on it? - what's the benefit you're hoping to achieve by being consistent with this approach?
Thanks, Sanne On 30 January 2017 at 09:55, Guillaume Smet <guillaume.s...@gmail.com> wrote: > Hi, > > So, with Gunnar, we did the work to rename the groupId and relocate the > artifacts of Validator. > > It would be nice if we could be consistent on the way we do it. > > So what we did: > - we created a relocation/ directory/parent artifact containing all the > relocation artifacts > - we only enable the build of the relocation artifacts if the relocation > profile is enabled (the release scripts are already updated to take this > new profile into account) > > See these commits for the details: > - > https://github.com/hibernate/hibernate-validator/commit/744b4c525c527e510648da8fed6c7e0fce8dd95c > - > https://github.com/hibernate/hibernate-noorm-release-scripts/commit/0fd44ecb06fd8269d8498affdd8e9c2a0c5836d4 > > If you have any question, feel free to ask. > > HTH > > -- > Guillaume > _______________________________________________ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
