You're right. For CollectionBinder, we shouldn't use the StringHelper.WHITESPACE. We should probably use a simple whitespace character. I guess that was the original intention.
Vlad On Tue, Feb 7, 2017 at 2:26 PM, Mark Rotteveel <m...@lawinegevaar.nl> wrote: > Any comments, or should I take the lack of answers as approval ;) > > Mark > > On 4-2-2017 15:05, Mark Rotteveel wrote: > > Firebird has a problem with some of the SQL generated by Hibernate, in > > some queries Hibernate appends StringHelper.WHITESPACE between > > conditions (specifically in CollectionBinder.bindFilters(boolean)). > > > > The problem is that StringHelper.WHITESPACE contains a formfeed (\f, > > 0x0C), and Firebird does not accept a formfeed as whitespace. > > > > It looks like the usage of StringHelper.WHITESPACE is wrong; the other > > places this constant is used is for splitting/tokenizing strings, and > > not for adding whitespace. > > > > Is there any objection if I replace the usage in > > CollectionBinder.bindFilters(boolean) with a single space (or maybe with > > " \n\t" to produce more similar SQL as previous)? > > > > Mark > > > > > -- > Mark Rotteveel > _______________________________________________ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
