Well, I don't think adding the test without the fix is the right thing to do.
When we will try to make this test work, we will have totally forgotten that there's a fix needed for that. That's why I listed the commits we couldn't merge for now as we will have to merge them later, once the feature has been implemented. And if you merge the tests and the fix at once, at least you know what you're doing. On Wed, Dec 19, 2018 at 7:21 PM Vlad Mihalcea <mihalcea.v...@gmail.com> wrote: > We need the tests to be available to know whether 6.0 has regressions than > 5.x. Therefore, all the pending tests become the list of tasks to be > integrated. > > Vlad > > On Wed, 19 Dec 2018, 19:40 Guillaume Smet <guillaume.s...@gmail.com wrote: > >> Hi Vlad, >> >> Not sure if it's better to partially push the commits or to have them in >> a list to deal with later (tests + commit). >> >> What do the others think about it? >> >> On Wed, Dec 19, 2018 at 6:37 PM Vlad Mihalcea <mihalcea.v...@gmail.com> >> wrote: >> >>> I have merged some PRs and have some commits still left to integrate >>> into 6. Indeed that some if them cannot be fully integrated because they >>> rely on non-implemented functionality. But I'll add the tests in the >>> pending tests folder. >>> >>> Vlad >>> >>> On Wed, 19 Dec 2018, 18:19 Guillaume Smet <guillaume.s...@gmail.com >>> wrote: >>> >>>> Hi, >>>> >>>> We had the first 5 -> 6 merge meeting with Chris yesterday. We >>>> cherry-picked all the simple things but there were a few more >>>> problematic >>>> things: >>>> - things that needs to be ported soon but weren't a simple cherry-pick >>>> - things that cannot be ported right now because not yet available in 6 >>>> >>>> We decided to push a document in the 6 tree containing the status so >>>> that >>>> we have proper versioning: >>>> >>>> https://github.com/hibernate/hibernate-orm/blob/wip/6.0/MERGE_STATUS.adoc >>>> >>>> Andrea, Chris and Vlad each have one issue affected. Maybe let's try to >>>> target the next meeting as the limit for merging them (or push them to >>>> kept >>>> for later), probably January 8th-9th. >>>> >>>> When you're done with a merge, please remove the related content from >>>> the >>>> document so that we can keep track of things. >>>> >>>> Thanks. >>>> >>>> -- >>>> Guillaume >>>> _______________________________________________ >>>> hibernate-dev mailing list >>>> hibernate-dev@lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>>> >>> _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
