If any getters or setters are final then the ProxyFactory cannot be used and imo should not get built, especially moving forward as we could use bytecode-based proxies
On Wed, Mar 4, 2020 at 2:11 PM Gail Badner <gbad...@redhat.com> wrote: > This commit [1] for HHH-11838 [2] causes an error to get logged by > ProxyFactoryHelper#validateProxyability [3] for a property that uses field > access and has a corresponding final getter/setter method. > > The logged error does not cause any failure, and the ByteBuddyProxyFactory > gets built. > > Should this error be logged in this case? > > When the error message is valid, should ByteBuddyProxyFactory not get > built? > > Thanks, > Gail > > [1] > > https://github.com/hibernate/hibernate-orm/commit/f8b78bcad0df43bd9b69fa5ee9d3bf10a3202318 > [2] https://hibernate.atlassian.net/browse/HHH-11838 > [3] > > https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/proxy/pojo/ProxyFactoryHelper.java#L87-L94 > _______________________________________________ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > > _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev