Gavin, Thanks for getting back to me. I read an earlier post where you had said something like this, but I was hoping you might reconsider. I agree that having something even more generic would be better, but having a count method now is absolutely critical to anyone wanting to use the Criteria API and needing to do paging. I also feel that the other methods like avg(), max(), etc, are not nearly as important as count() for most people. I certainly understand the slippery slope idea, but I'm not sure it has to apply here. I would be willing to commit to refactoring, removing, or doing whatever is needed to adapt this method to fit in with the aggregation functionality when it comes along. I'd much rather do that than have to redo this patch for each release of Hibernate in the meanwhile. I also think there are people who may need this method who may be uncomfortable with using a patched version of Hibernate.
Incidentally, I'd be happy to be involved in developing the aggregation functionality if I can be helpful. It seems like making the Select statement objectb available to sublasses might be a first step in that direction anyways. Of course, there seems to be some talk about having Criteria generate HQL and SQL with the new AST stuff (an idea which I rather like if it's feasible), so maybe not. Thanks again, Chris Nelson --- Gavin King <[EMAIL PROTECTED]> wrote: > Hi, I apologise. > > Me not answering emails generally means I don't > quite know what to say > and am still thinking something through. > > Anyway, as I've indicated elsewhere, I don't want > this stuff in the > Criteria API *yet*. We havn't decided how we should > implement > projection/aggregation yet, and when we do, it won't > be by adding 1000 > methods like count(), avg(), max(), etc to the > Criteria interface. > > Anyone who really needs this _now_ can use your > patch, I suppose. > > peace > > Gavin > > Chris Nelson wrote: > > > Guys, > > > > This is the 3rd time I have sent an email > regarding > > this, and I'm starting to wonder if I have virtual > bad > > breath or something ;) I'm hoping maybe people > > thought I was asking where is this method so I > tried > > to make my subject a little more explicit this > time. > > > > I submitted a patch (2 of em actually) to add the > > count() method to Criteria after seeing several > posts > > about not having it and needing it myself. Is > there a > > chance someone can look at it and tell me if it's > ok? > > It's HB-474, and the second attachment is the > > corrected one (the first had an issue when used > with > > limit queries). > > > > Thanks in advance, > > > > Chris Nelson > > > > > > > > __________________________________ > > Do you Yahoo!? > > Free Pop-Up Blocker - Get it now > > http://companion.yahoo.com/ > > > > > > > ------------------------------------------------------- > > This SF.net email is sponsored by: SF.net Giveback > Program. > > Does SourceForge.net help you be more productive? > Does it > > help you create better code? SHARE THE LOVE, and > help us help > > YOU! Click Here: http://sourceforge.net/donate/ > > _______________________________________________ > > hibernate-devel mailing list > > [EMAIL PROTECTED] > > > https://lists.sourceforge.net/lists/listinfo/hibernate-devel > > -- > Gavin King > JBoss Group > +61 410534454 > http://hibernate.org > __________________________________ Do you Yahoo!? Free Pop-Up Blocker - Get it now http://companion.yahoo.com/ ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ hibernate-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/hibernate-devel
