On Mon, Aug 23, 2010 at 08:54:40PM +0200, Mircea Gherzan wrote: > > Feedback is welcomed :)
The subject line you send is a slight improvement, the body of the message is IMO not. It no longer contains all the useful information that launchpad puts above the diff. > #!/bin/sh > # get the HEAD revision (the last one) > head=`bzr log | head -2 | tail -1 | cut -f 2 -d ' '` bzr revno Also, $() is better than ``, it's easier to nest, same below. > # lastrev was already processed, so incrementing it > lastrev=`expr $lastrev + 1` $(($lastrev + 1)) > # create the body of the e-mail > true > $MAILBUF 'true' unneeded. Diego _______________________________________________ Mailing list: https://launchpad.net/~hipl-core Post to : [email protected] Unsubscribe : https://launchpad.net/~hipl-core More help : https://help.launchpad.net/ListHelp
