On Sun, 29 Aug 2010 17:50:12 +0200, Diego Biurrun <[email protected]> wrote:

Maybe the following part of the HACKING document is in need of rephrasing:

  Long lines (>80 characters) should be broken at suitable places
  where doing so improves readability.

--->

  Long lines (>80 characters) should be broken at suitable places
  if and only if doing so improves readability.

Is the latter clearer?

Hum... so reformatting this (A)

            ctx->transport_hdr.tcp = (struct tcphdr*)
                    (((char *) ip6_hdr) + sizeof(struct ip6_hdr));

to this (B)

            ctx->transport_hdr.tcp = (struct tcphdr*)
(((char *) ip6_hdr) + sizeof(struct ip6_hdr));

rather than this (C)

            ctx->transport_hdr.tcp = (struct tcphdr*)
                                     (((char *) ip6_hdr) +
                                      sizeof(struct ip6_hdr));

is recommended even though in (B) the second line is slightly longer than 80 characters (and (A) still looks readable, imho) while in (C) it is within the threshold?

_______________________________________________
Mailing list: https://launchpad.net/~hipl-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~hipl-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to