On Mon, Sep 13, 2010 at 10:21:09PM +0200, Christof Mroz wrote: > On Mon, 13 Sep 2010 18:35:34 +0200, Diego Biurrun <[email protected]> wrote: > >>> Removed superfluous typedef. Some const, cosmetic and doc changes. >> >> This mixes several independent changes. > > I actually tried to shelve most of these because they're related imho: > Not supposed to alter program logic etc.
The keyword here is "supposed". You can never guarantee that none of these changes will have other issues. Commits should be as atomic as possible, period. There simply are no sensible exceptions to this rule. >> Did you do a mechanical substitution and never look at the diff before >> committing? > > No and no Well, then you should catch these mistakes :) Diego _______________________________________________ Mailing list: https://launchpad.net/~hipl-core Post to : [email protected] Unsubscribe : https://launchpad.net/~hipl-core More help : https://help.launchpad.net/ListHelp
