Hi Jun, You're right, setting node to null was on the wrong location if for example there is another property to set after skipping a property with overwrite=false. Thank you for spotting the bug. I moved the node=null to the end of the method, after the properties iterator. I've created a release (1.01.03) with this fix.
Regards, Jasha Joachimsthal [EMAIL PROTECTED] - [EMAIL PROTECTED] www.onehippo.com Amsterdam - Hippo B.V. Oosteinde 11 1017 WT Amsterdam +31(0)20-5224466 San Francisco - Hippo USA Inc. 101 H Street, suite Q Petaluma CA 94952-3329 +1 (707) 773-4646 > -----Original Message----- > From: Niels van Kampenhout > Sent: dinsdag 21 oktober 2008 23:24 > To: [EMAIL PROTECTED] > Cc: Jasha Joachimsthal; Hippo CMS development public mailinglist > Subject: Re: Hippo-CMS: Bug fix for setproperties > > Hi Jun, > > Thanks for your contribution, much appreciated! > > We have a public Jira for our products like CMS and Portal, > but for small tools like setproperties you can best send > patches to the hippocms-dev mailing list (to which I have > CC'ed this reply). I am sure Jasha or someone else will be > happy to review and apply your patch. > > Regards, > > Niels > > > > [EMAIL PROTECTED] wrote: > > Hi Jasha and Neils, > > > > I see your names on > http://www.hippocms.org/display/CMS/Hippo+Setproperties, so I > assumed that you are the owners of the setproperties tool. > > > > I found a bug in the tool where only one property gets set > for a file, rather than all properties specified in the > setproperties.property file. > > > > The fix is very simple: remove the node=null; lines from > the two finally clauses. I have attached my version for your review. > > > > Another question for you guys are: what's the formal > process of submitting a bug fix? I already learnt from Bart > that there is no open Hippo JIRA area for public. > > > > Thanks > > > > Jun Ni > > Senior Software Engineer > > FindLaw, a Thomson Reuters Business > > 800 West California Ave. > > Sunnyvale, CA 95014 > > 408-524-4723 > > www.findlaw.com > > > > > > -- > Niels van Kampenhout > > [EMAIL PROTECTED] www.onehippo.com > > EUROPE > Hippo B.V. Oosteinde 11 1017 WT Amsterdam +31(0)20-5224466 > > USA > Hippo USA Inc. 101 H Street, Suite Q Petaluma CA 94952-3329 > +1 (877) 41-HIPPO > > ________________________________________________________________ > This e-mail may be privileged and/or confidential, and the > sender does not waive any related rights and obligations. Any > distribution, use or copying of this e-mail or the > information it contains by other than an intended recipient > is unauthorized. If you received this e-mail in error, please > advise me (by return e-mail or otherwise) immediately. > > ******************************************** Hippocms-dev: Hippo CMS development public mailinglist Searchable archives can be found at: MarkMail: http://hippocms-dev.markmail.org Nabble: http://www.nabble.com/Hippo-CMS-f26633.html
