Hi Francesco, I tested your patch and committed it to the 6.05 branch and the trunk. Thanks for spotting the feature.
Jasha Joachimsthal [email protected] - [email protected] www.onehippo.com Amsterdam - Hippo B.V. Oosteinde 11 1017 WT Amsterdam +31(0)20-5224466 San Francisco - Hippo USA Inc. 185 H Street, suite B, Petaluma CA 94952 +1 (707) 7734646 On 23 December 2009 12:09, Bart van der Schans <[email protected]>wrote: > Hi Francesco, > > I've created a jira issue for this: > https://issues.onehippo.com/browse/CMSSIX-273 > > Thx for the feedback! > > Bart > > > 2009/11/26 Francesco Chicchiriccò <[email protected]>: > > Hi all, > > I've just finished a run of tests and checks with the spell checker. > > > > My configuration as follows: > > > > * Hippo 6.05.07 with Xinha 0.9.5 / a brand new Hippo 6.05.08 without > > any modification > > * Apache Tomcat 6.0.20 > > * Solaris 10 x86 / SPARC > > > > In all cases, I found that it is mandatory to set, among Tomcat's JVM > > properties, the file.encoding property to UTF-8 in order for the spell > > checker to work at all. > > > > Moreover, the AspellGenerator ([1]) has a bug around line 188: > > > > newline = newline.replaceAll(word,"<span > > class='HA-spellcheck-error'>"+word+"</span> "); > > > > I had to replace this line with: > > > > newline = newline.replaceAll("\\b" + word + "\\b", "<span > > class='HA-spellcheck-error'>" + word + "</span>"); > > > > As you can see, my modification has the purpose of replacing only entire > > words instead of substrings. > > With the original line, an English text containing the word "check" could > > cause problems if the default dictionary was the Italian one: since > "check" > > is not an Italian word, the replaceAll(() above would result in all the > > "check" occurences get replaced, also the one included in the class > > attribute of the <span/> element, thus resulting in an invalid XML. > > > > With these modifications, I've been able to successfully test the spell > > checker with Italian, English, Polish, German, French and Portuguese. > > > > Cheers. > > > > [1] > > > http://svn.hippocms.org/repos/hippo/hippo-cms/tags/Release-CMS-v6_05_07/editor/src/java/nl/hippo/cms/spellchecking/generation/AspellGenerator.java > > -- > > > > Francesco Chicchiriccò > > Delivery Manager > > > > everett Italia ? > > TRUSTED TO *KNOW* > > > > Head Office > > Via Torino, 2 - 20123 Milano - Italia > > Tel: > > +39 02 72546847 > > Fax: > > +39 02 72546418 > > Technology Centre > > Via Federico Fellini, 2 G2/1 - 65010 Spoltore (PE) - Italia > > Tel: > > +39 085 2120342 / +39 085 2120537 > > Fax: > > +39 085 2120342 / +39 085 2120537 > > > > Mob: > > +39 329 0573276 > > e-mail: > > [email protected] <mailto: > [email protected]> > > Web: > > http://www.everett.it > > > > The information in this Internet email is confidential and may be legally > > privileged. It is intended solely for the addressee. Access to this > Internet > > email by anyone else is unauthorised. If you are not the intended > recipient, > > any disclosure, copying, distribution or any action taken or omitted to > be > > taken in reliance on it is prohibited and may be unlawful. When addressed > to > > our clients any opinions or advice contained in this Internet email are > > subject to the terms and conditions expressed in any applicable governing > > Everett terms of business or client engagement letter. > > > > ******************************************** > > Hippocms-dev: Hippo CMS development public mailinglist > > > > Searchable archives can be found at: > > MarkMail: http://hippocms-dev.markmail.org > > Nabble: http://www.nabble.com/Hippo-CMS-f26633.html > > > > > > > > -- > Hippo B.V. - Amsterdam > Oosteinde 11, 1017 WT, Amsterdam, +31(0)20-5224466 > > Hippo USA Inc. - San Francisco > 101 H Street, Suite Q, Petaluma CA, 94952-3329, +1 (707) 773-4646 > ----------------------------------------------------------------- > http://www.onehippo.com - [email protected] > ----------------------------------------------------------------- > ******************************************** > Hippocms-dev: Hippo CMS development public mailinglist > > Searchable archives can be found at: > MarkMail: http://hippocms-dev.markmail.org > Nabble: http://www.nabble.com/Hippo-CMS-f26633.html > > ******************************************** Hippocms-dev: Hippo CMS 6 development public mailinglist Searchable archives can be found at: MarkMail: http://hippocms-dev.markmail.org Nabble: http://www.nabble.com/Hippo-CMS-f26633.html
