Tobias Jeger pushed to branch feature/visual-editing-psp1 at cms-community /
hippo-addon-channel-manager
Commits:
4b5932d5 by Tobias Jeger at 2016-09-14T10:53:49+02:00
CHANNELMGR-840 Improve decoupling of side panel templates and service
- - - - -
1 changed file:
- frontend-ng/src/angularjs/channel/sidePanels/sidePanel.service.js
Changes:
=====================================
frontend-ng/src/angularjs/channel/sidePanels/sidePanel.service.js
=====================================
--- a/frontend-ng/src/angularjs/channel/sidePanels/sidePanel.service.js
+++ b/frontend-ng/src/angularjs/channel/sidePanels/sidePanel.service.js
@@ -20,22 +20,20 @@ export class ChannelSidePanelService {
this.$mdSidenav = $mdSidenav;
this.ScalingService = ScalingService;
- this.panels = {
- left: {
- element: 'channel-left-side-panel',
- },
- right: {
- element: 'channel-right-side-panel',
- },
- };
+ this.panels = { };
}
initialize(side, jQueryElement) {
- this.panels[side].jQueryElement = jQueryElement;
+ const panel = {
+ jQueryElement,
+ sideNavComponentId: jQueryElement.attr('md-component-id'),
+ };
+
+ this.panels[side] = panel;
}
toggle(side) {
- this.$mdSidenav(this.panels[side].element).toggle();
+ this.$mdSidenav(this.panels[side].sideNavComponentId).toggle();
if (side === 'left') {
// TODO: Remove this when scaling is fixed
@@ -45,17 +43,17 @@ export class ChannelSidePanelService {
open(side) {
if (!this.isOpen(side)) {
- this.$mdSidenav(this.panels[side].element).open();
+ this.$mdSidenav(this.panels[side].sideNavComponentId).open();
}
}
isOpen(side) {
- return this.panels[side].jQueryElement &&
this.$mdSidenav(this.panels[side].element).isOpen();
+ return this.panels[side] &&
this.$mdSidenav(this.panels[side].sideNavComponentId).isOpen();
}
close(side) {
if (this.isOpen(side)) {
- this.$mdSidenav(this.panels[side].element).close();
+ this.$mdSidenav(this.panels[side].sideNavComponentId).close();
if (side === 'left') {
// TODO: Remove this when scaling is fixed
View it on GitLab:
https://code.onehippo.org/cms-community/hippo-addon-channel-manager/commit/4b5932d58801be1354668c19eb243034f28e6c3f
_______________________________________________
Hippocms-svn mailing list
Hippocms-svn@lists.onehippo.org
https://lists.onehippo.org/mailman/listinfo/hippocms-svn
