Mathijs den Burger pushed to branch feature/visual-editing-psp1-CHANNELMGR-915 at cms-community / hippo-addon-channel-manager
Commits: 245f309a by Mathijs den Burger at 2016-10-21T13:35:17+02:00 CHANNELMGR-843 Fix right side-panel tests - - - - - 61613dd7 by Mathijs den Burger at 2016-10-21T13:38:37+02:00 CHANNELMGR-915 Merge feature/visual-editing-psp1 changes - - - - - 1 changed file: - frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/rightSidePanel.spec.js Changes: ===================================== frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/rightSidePanel.spec.js ===================================== --- a/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/rightSidePanel.spec.js +++ b/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/rightSidePanel.spec.js @@ -71,7 +71,7 @@ describe('ChannelRightSidePanel', () => { $timeout = _$timeout_; }); - ChannelSidePanelService = jasmine.createSpyObj('ChannelSidePanelService', ['initialize', 'close']); + ChannelSidePanelService = jasmine.createSpyObj('ChannelSidePanelService', ['initialize', 'isOpen', 'close']); ContentService = jasmine.createSpyObj('ContentService', ['createDraft', 'getDocumentType']); $scope = $rootScope.$new(); @@ -96,15 +96,13 @@ describe('ChannelRightSidePanel', () => { }); it('knows when it is locked open', () => { - const ctrl = instantiateController(); - spyOn(ChannelSidePanelService, 'isOpen').and.returnValue(true); - expect(ctrl.isLockedOpen()).toBe(true); + ChannelSidePanelService.isOpen.and.returnValue(true); + expect($ctrl.isLockedOpen()).toBe(true); }); it('knows when it is not locked open', () => { - const ctrl = instantiateController(); - spyOn(ChannelSidePanelService, 'isOpen').and.returnValue(false); - expect(ctrl.isLockedOpen()).toBe(false); + ChannelSidePanelService.isOpen.and.returnValue(false); + expect($ctrl.isLockedOpen()).toBe(false); }); it('closes the panel', () => { View it on GitLab: https://code.onehippo.org/cms-community/hippo-addon-channel-manager/compare/89473e49b1dc04fc35254005fb9762f4a60709fd...61613dd793272638a582304b8922008ffeb77c41
_______________________________________________ Hippocms-svn mailing list Hippocms-svn@lists.onehippo.org https://lists.onehippo.org/mailman/listinfo/hippocms-svn