Mathijs den Burger pushed to branch feature/visual-editing-psp1-CHANNELMGR-1055
at cms-community / hippo-addon-channel-manager
Commits:
9cfd58a5 by Mathijs den Burger at 2016-12-16T16:59:03+01:00
CHANNELMGR-1055 Revert: make functions static where possible
- - - - -
1 changed file:
-
frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/rightSidePanel.controller.js
Changes:
=====================================
frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/rightSidePanel.controller.js
=====================================
---
a/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/rightSidePanel.controller.js
+++
b/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/rightSidePanel.controller.js
@@ -133,11 +133,11 @@ class RightSidePanelCtrl {
.finally(() => delete this.loading);
}
- static _hasFields(doc) {
+ _hasFields(doc) {
return doc.fields && Object.keys(doc.fields).length > 0;
}
- static _noContentResponse(doc) {
+ _noContentResponse(doc) {
return {
data: {
reason: 'NO_CONTENT',
@@ -179,7 +179,7 @@ class RightSidePanelCtrl {
this._handleErrorResponse(errorKey, params);
}
- static _extractErrorParams(errorInfo) {
+ _extractErrorParams(errorInfo) {
const params = {};
if (errorInfo.reason === 'OTHER_HOLDER') {
params.user = errorInfo.params.userName || errorInfo.params.userId;
@@ -237,11 +237,11 @@ class RightSidePanelCtrl {
});
}
- static _isDocument(obj) {
+ _isDocument(obj) {
return obj && obj.id; // Document has an ID field, ErrorInfo doesn't.
}
- static _isErrorInfo(obj) {
+ _isErrorInfo(obj) {
return obj && obj.reason; // ErrorInfo has a reason field, Document
doesn't.
}
View it on GitLab:
https://code.onehippo.org/cms-community/hippo-addon-channel-manager/commit/9cfd58a5af1c270e4efff37a519570caef42a0bf
_______________________________________________
Hippocms-svn mailing list
Hippocms-svn@lists.onehippo.org
https://lists.onehippo.org/mailman/listinfo/hippocms-svn
