Michiel Rop pushed to branch feature/wpm-refactoring at cms-community / hippo-repository
Commits: dd15b9ae by Michiel Rop at 2017-03-20T10:07:00+01:00 REPO-1634: Change access modifier to public to expose methods In order to be able to wrap the DocumentHandle instead of overriding it in another package the following methods need to be publicly accessible: * createDocumentVariant * createRequest * isInitialized - - - - - 3ef3f6a3 by Michiel Rop at 2017-03-20T10:07:31+01:00 REPO-1634: Make setWorkflowContext overridable. The setWorkflowContext method is called from org/hippoecm/repository/impl/WorkflowManagerImpl.java:294 When wrapping this class the method needs public access in order to be able to override it in another package without extending it. - - - - - 00c8bf15 by Michiel Rop at 2017-03-20T10:08:08+01:00 REPO-1634: Give method getWorkflowExecutor public access - - - - - bde6bd4b by Michiel Rop at 2017-03-20T10:09:00+01:00 REPO-1634: Update copyright headers - - - - - 3 changed files: - api/src/main/java/org/hippoecm/repository/ext/WorkflowImpl.java - workflow/src/main/java/org/onehippo/repository/documentworkflow/DocumentHandle.java - workflow/src/main/java/org/onehippo/repository/documentworkflow/DocumentWorkflowImpl.java Changes: ===================================== api/src/main/java/org/hippoecm/repository/ext/WorkflowImpl.java ===================================== --- a/api/src/main/java/org/hippoecm/repository/ext/WorkflowImpl.java +++ b/api/src/main/java/org/hippoecm/repository/ext/WorkflowImpl.java @@ -1,5 +1,5 @@ /* - * Copyright 2008-2013 Hippo B.V. (http://www.onehippo.com) + * Copyright 2008-2017 Hippo B.V. (http://www.onehippo.com) * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -53,7 +53,7 @@ public abstract class WorkflowImpl implements Remote, Workflow * <b>This call is not (yet) part of the API, but under evaluation.</b><p/> * @param context the new context that should be used */ - final public void setWorkflowContext(WorkflowContext context) { + public void setWorkflowContext(WorkflowContext context) { this.context = context; } ===================================== workflow/src/main/java/org/onehippo/repository/documentworkflow/DocumentHandle.java ===================================== --- a/workflow/src/main/java/org/onehippo/repository/documentworkflow/DocumentHandle.java +++ b/workflow/src/main/java/org/onehippo/repository/documentworkflow/DocumentHandle.java @@ -1,5 +1,5 @@ /* - * Copyright 2013-2015 Hippo B.V. (http://www.onehippo.com) + * Copyright 2013-2017 Hippo B.V. (http://www.onehippo.com) * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -49,15 +49,15 @@ public class DocumentHandle implements SCXMLWorkflowData { this.handle = handle; } - protected DocumentVariant createDocumentVariant(Node node) throws RepositoryException { + public DocumentVariant createDocumentVariant(Node node) throws RepositoryException { return new DocumentVariant(node); } - protected Request createRequest(Node node) throws RepositoryException { + public Request createRequest(Node node) throws RepositoryException { return Request.createRequest(node); } - protected boolean isInitialized() { + public boolean isInitialized() { return initialized; } ===================================== workflow/src/main/java/org/onehippo/repository/documentworkflow/DocumentWorkflowImpl.java ===================================== --- a/workflow/src/main/java/org/onehippo/repository/documentworkflow/DocumentWorkflowImpl.java +++ b/workflow/src/main/java/org/onehippo/repository/documentworkflow/DocumentWorkflowImpl.java @@ -88,7 +88,7 @@ public class DocumentWorkflowImpl extends WorkflowImpl implements DocumentWorkfl return new DocumentHandle(node); } - SCXMLWorkflowExecutor getWorkflowExecutor() { + public SCXMLWorkflowExecutor getWorkflowExecutor() { return workflowExecutor; } View it on GitLab: https://code.onehippo.org/cms-community/hippo-repository/compare/e0aedfa23cb2a1ed4dee43ff795f7a07f5e87eae...bde6bd4ba29d61af46468418e2f96d2bb103af48
_______________________________________________ Hippocms-svn mailing list Hippocms-svn@lists.onehippo.org https://lists.onehippo.org/mailman/listinfo/hippocms-svn
