[HippoCMS-scm] [Git][cms-community/hippo-repository][feature/REPO-1822] REPO-1822 in URI encoding, treat quote-like characters as quote, so remove them,…

[Jeroen Hoffman]

Jeroen Hoffman pushed to branch feature/REPO-1822 at cms-community / 
hippo-repository


Commits:
cfbff022 by Jeroen Hoffman at 2017-09-21T09:48:19+02:00
REPO-1822 in URI encoding, treat quote-like characters as quote, so remove 
them, because quotes cannot be used in JCR node names

- - - - -


2 changed files:

- api/src/main/java/org/hippoecm/repository/api/StringCodecFactory.java
- api/src/test/java/org/hippoecm/repository/api/UriEncodingTest.java


Changes:

=====================================
api/src/main/java/org/hippoecm/repository/api/StringCodecFactory.java
=====================================
--- a/api/src/main/java/org/hippoecm/repository/api/StringCodecFactory.java
+++ b/api/src/main/java/org/hippoecm/repository/api/StringCodecFactory.java
@@ -525,14 +525,14 @@ public class StringCodecFactory {
                         case 0x2015: sb.append("-");    break; // ―
                         case 0x2016: sb.append("-");    break; // ‖
                         case 0x2017: sb.append("-");    break; // ‗
-                        case 0x2018: sb.append("'");    break; // ‘ (left 
single quotation)
-                        case 0x2019: sb.append("'");    break; // ’ (right 
single quotation)
-                        case 0x201a: sb.append("'");    break; // ‚
-                        case 0x201b: sb.append("'");    break; // ‛
-                        case 0x201c: sb.append("'");    break; // “
-                        case 0x201d: sb.append("'");    break; // ”
-                        case 0x201e: sb.append("'");    break; // „
-                        case 0x201f: sb.append("'");    break; // ‟
+                        case 0x2018: break; // ‘ (left single quotation) treat 
quote-like characters as quote: remove
+                        case 0x2019: break; // ’ (right single quotation)
+                        case 0x201a: break; // ‚
+                        case 0x201b: break; // ‛
+                        case 0x201c: break; // “
+                        case 0x201d: break; // ”
+                        case 0x201e: break; // „
+                        case 0x201f: break; // ‟
 
                         // 0xac00 - 0xd7a3 : Hangul Syllables (only some of 
them are encoded)
                         case 0xc2a0:


=====================================
api/src/test/java/org/hippoecm/repository/api/UriEncodingTest.java
=====================================
--- a/api/src/test/java/org/hippoecm/repository/api/UriEncodingTest.java
+++ b/api/src/test/java/org/hippoecm/repository/api/UriEncodingTest.java
@@ -78,7 +78,7 @@ public class UriEncodingTest {
               
uri.encode("ĀāĂ㥹ĆćĈĉĊċČčĎďĐđĒēĔĕĖėĘęĚěĜĝĞğĠġĢģĤĥĦħĨĩĪīĬĭĮįİıIJijĴĵĶķĸĹĺĻļĽľĿŀŁłŃńŅņŇňʼnŊŋŌōŎŏŐőŒœŔŕŖŗŘřŚśŜŝŞşŠšŢţŤťŦŧŨũŪūŬŭŮůŰűŲųŴŵŶŷŸŹźŻżŽžſ"));
 
         // 0x201x subrange of Unicode General Punctuation
-        assertEquals("--------''''''''", uri.encode("‐‑‒–—―‖‗‘’‚‛“”„‟"));
+        assertEquals("--------with-ending", 
uri.encode("‐‑‒–—―‖‗‘’‚‛“”„‟with-ending"));
 
         // trailing dots
         assertEquals("abc", uri.encode("abc."));



View it on GitLab: 
https://code.onehippo.org/cms-community/hippo-repository/commit/cfbff0229ca953c3462508aaa99b22b078aae4f5

---
View it on GitLab: 
https://code.onehippo.org/cms-community/hippo-repository/commit/cfbff0229ca953c3462508aaa99b22b078aae4f5
You're receiving this email because of your account on code.onehippo.org.

_______________________________________________
Hippocms-svn mailing list
Hippocms-svn@lists.onehippo.org
https://lists.onehippo.org/mailman/listinfo/hippocms-svn