Arthur Bogaart pushed to branch feature/CC-CHANNELMGR-1563 at cms-community / hippo-addon-channel-manager
Commits: 7ddcc4a5 by Ariel Weinberger at 2017-11-13T11:21:19+01:00 CHANNELMGR-1543 Implement $postLink to left and right side panels, to initialize the $mdSidenav after the view has loaded - - - - - 1e300caf by Ariel Weinberger at 2017-11-13T11:21:56+01:00 CHANNELMGR-1543 Add right side panel method "_beforeClosePanel", previously was called "_onClose" - - - - - 5d5cfe5b by Ariel Weinberger at 2017-11-13T11:22:39+01:00 CHANNELMGR-1543 Make unit test changes according to recent variable name changes and trigger $postLink - - - - - 125a1f85 by Ariel Weinberger at 2017-11-13T15:40:57+01:00 CHANNELMGR-1543 Service calls onCloseCallback when the sidenav is closed by the ESC key - - - - - 84e0d79b by Arthur Bogaart at 2017-11-13T16:55:30+01:00 CHANNELMGR-1575 Add tooltips to main button - - - - - 8a84460c by Ariel Weinberger at 2017-11-13T17:01:16+01:00 CHANNELMGR-1543 Add unit tests to make SidePanelService fully covered - - - - - 8faea2ae by Ariel Weinberger at 2017-11-13T17:04:31+01:00 CHANNELMGR-1543 Add another expect expression to the tests and fix failing test for lowerSidePanelBeneathMask - - - - - e3567ac8 by Mathijs den Burger at 2017-11-14T11:40:15+01:00 CHANNELMGR-1568 Prevent NPE when encoding or setting names The UriEncoder throws a NPE when encoding null. Prevent that by always returning null when encoding a null value. When reading the old URL name fails (because JcrUtils#getNodeNameQuietly returns null), comparing the old and new URL name would throw an NPE. Prevent that by using StringUtils#equals. - - - - - 64afdae2 by Michael Metternich at 2017-11-14T15:25:25+01:00 CHANNELMGR-1488 Improve warning messages - - - - - 348446d6 by Ariel Weinberger at 2017-11-14T16:46:43+01:00 CHANNELMGR-1565 Add and modify QA classes for step 1 and step 2 of create content - - - - - a5203ffe by Michael Metternich at 2017-11-14T21:39:00+01:00 CHANNELMGR-1488 Match unit tests to information in thrown errors - - - - - 6d87c29a by Arthur Bogaart at 2017-11-15T01:00:13+01:00 CHANNELMGR-1586 Enable lint in frontend-ng Fixed two lint errors. - - - - - 24291184 by Ariel Weinberger at 2017-11-15T13:22:56+01:00 CHANNELMGR-1543 Refactor sidePanelService to avoid recursive call of $mdSidenav.close(), routing close handling to the native $mdSidenav object - - - - - e9e7e1d0 by Ariel Weinberger at 2017-11-15T13:23:19+01:00 CHANNELMGR-1543 Fix unit tests for SidePanelService to reach full coverage - - - - - 76e3970f by Ariel Weinberger at 2017-11-15T13:23:50+01:00 CHANNELMGR-1543 Remove leftover console log - - - - - 71f0f30f by Ariel Weinberger at 2017-11-15T13:24:50+01:00 CHANNELMGR-1543 Reintegrate branch 'feature/CC-CHANNELMGR-1543' into feature/create-content - - - - - 3dd1af4b by Ariel Weinberger at 2017-11-15T13:50:49+01:00 CHANNELMGR-1560 Fix zone.js related errors in name-url-fields - - - - - 94ca6194 by Ariel Weinberger at 2017-11-15T13:54:17+01:00 Merge branch 'feature/CC-CHANNELMGR-1560' into feature/create-content - - - - - e1a7067a by Ariel Weinberger at 2017-11-15T14:10:23+01:00 CHANNELMGR-1543 Fix linting errors - - - - - 7cc24507 by Ariel Weinberger at 2017-11-15T14:11:09+01:00 CHANNELMGR-1543 Fix linting errors - - - - - 469567cb by Mathijs den Burger at 2017-11-15T15:06:23+01:00 CHANNELMGR-1568 Add EditingUtils#canRenameDocument - - - - - 291bdb0a by Mathijs den Burger at 2017-11-16T07:52:49+01:00 CHANNELMGR-1568 Update display name and URL name in separate PUT call Allows updating the names of a document without side-effects. Updating the names as part of the draft call would also save all fields and create a preview version of the document. Updating document names accepts a document. Only the displayName and urlName properties in it are actually used. Both are encoded again by the backend, so the frontend can pass the not-yet-encoded version of these fields (mainly relevant for manually set URL names). Use the DocumentWorkflow to set the URL name, so the workflow prevents illegal cases (e.g. renaming a published document). The exception is renaming an new draft document (e.g. without a preview version yet), which is not possible via DocumentWorkflow. For that specific case the DefaultWorkflow is used, which always allows renaming. The utility methods to retrieve a certain workflow have been moved to a separate class ContentWorkflowUtils, which is now used by both the DocumentServiceImpl and the DocumentNameUtils. - - - - - c228e44b by Mathijs den Burger at 2017-11-16T08:12:43+01:00 CHANNELMGR-1568 Don't update the URL name if the display name clashes First check that neither the URL name nor the display name clash with sibling documents before updating either of them. Otherwise the case where both are changed but the display name clashes is not handled correctly. The URL may already have been updated via workflow before an error is returned because the display name clashes with an existing node. Because the URL is updated via workflow in a separate session, the new URL name would already have been persisted. That should not happen: either both the display name and url name are changed, or neither of them are. Added a unit test for this case, and reshuffled the existing tests a bit to better reflect the new code ordering. - - - - - 3e05ab8a by Ariel Weinberger at 2017-11-16T10:34:22+01:00 CHANNELMGR-1575 Reintegrate branch 'feature/CC-CHANNELMGR-1575' into feature/create-content - - - - - 9d2c477b by Michael Metternich at 2017-11-16T14:57:41+01:00 CHANNELMGR-1568 Minor code quality improvements - - - - - 7ca64c24 by Mathijs den Burger at 2017-11-17T12:25:04+01:00 CHANNELMGR-1568 Improve private method name in unit test The document names should not be updated. Pass the reason so the method can also be used to assert the case where the slug already exists. - - - - - 8df8bb81 by Mathijs den Burger at 2017-11-17T14:13:14+01:00 CHANNELMGR-1568 Reintegrate 'feature/CC-CHANNELMGR-1513' into feature/create-content Only the backend part of CHANNELMGR-1513 is reintegrated to get the mainline branch in a stable state. Reverted the ExceptionWithPayloadExceptions that got a string as payload. A string won't be parsed as valid JSON in the frontend. Better log the message as a warning and only include an ErrorInfo object as payload. - - - - - 31732be6 by Mathijs den Burger at 2017-11-17T14:37:38+01:00 CHANNELMGR-1568 Accept only ErrorInfo or Document as error payload A string payload won't be parsed as valid JSON by the front-end. Changed the signature of all concrete ErrorWithPayloadExceptions to only accept an ErrorInfo object, so invalid cases (like a string) are caught by the compiler. The exception was the BadRequestException, which is also used by DocumentServiceImpl#updateDraft to return a document as payload. Added a second constructor for that case. This exercise also found two erroneous cases of an InternalServerErrorException that got an exception as payload (in DocumentServiceImpl#archiveDocument and #eraseDocument). Such cases will now be avoided. - - - - - 401767dc by Arthur Bogaart at 2017-11-20T09:32:41+01:00 CHANNELMGR-1563 Merge feature/create-content changes - - - - - 30 changed files: - content-service/src/main/java/org/onehippo/cms/channelmanager/content/ContentResource.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/document/DocumentsService.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/document/DocumentsServiceImpl.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/document/model/Document.java - + content-service/src/main/java/org/onehippo/cms/channelmanager/content/document/util/ContentWorkflowUtils.java - − content-service/src/main/java/org/onehippo/cms/channelmanager/content/document/util/DisplayNameUtils.java - + content-service/src/main/java/org/onehippo/cms/channelmanager/content/document/util/DocumentNameUtils.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/document/util/EditingUtils.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/error/BadRequestException.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/error/ConflictException.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/error/ErrorInfo.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/error/ForbiddenException.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/error/InternalServerErrorException.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/error/MethodNotAllowed.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/folder/FoldersServiceImpl.java - content-service/src/test/java/org/onehippo/cms/channelmanager/content/ContentResourceTest.java - content-service/src/test/java/org/onehippo/cms/channelmanager/content/document/DocumentsServiceImplTest.java - + content-service/src/test/java/org/onehippo/cms/channelmanager/content/document/util/ContentWorkflowUtilsTest.java - content-service/src/test/java/org/onehippo/cms/channelmanager/content/document/util/DisplayNameUtilsTest.java → content-service/src/test/java/org/onehippo/cms/channelmanager/content/document/util/DocumentNameUtilsTest.java - content-service/src/test/java/org/onehippo/cms/channelmanager/content/document/util/EditingUtilsTest.java - content-service/src/test/resources/log4j-filters.txt - frontend-ng/pom.xml - frontend-ng/src/app/channel/hippoIframe/overlay/overlay.service.js - frontend-ng/src/app/channel/hippoIframe/overlay/overlay.service.spec.js - frontend-ng/src/app/channel/sidePanels/leftSidePanel/leftSidePanel.controller.js - frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/document-location/document-location-field.html - frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/name-url-fields/name-url-fields.component.spec.ts - frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/name-url-fields/name-url-fields.component.ts - frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/name-url-fields/name-url-fields.html - frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/step-1/step-1.html The diff was not included because it is too large. View it on GitLab: https://code.onehippo.org/cms-community/hippo-addon-channel-manager/compare/f76f6aa40ff35ead2033605c2f8e309e424a8510...401767dcd0d12595e7dbbb4030e9ac2433f00f76 --- View it on GitLab: https://code.onehippo.org/cms-community/hippo-addon-channel-manager/compare/f76f6aa40ff35ead2033605c2f8e309e424a8510...401767dcd0d12595e7dbbb4030e9ac2433f00f76 You're receiving this email because of your account on code.onehippo.org.
_______________________________________________ Hippocms-svn mailing list Hippocms-svn@lists.onehippo.org https://lists.onehippo.org/mailman/listinfo/hippocms-svn
