[
https://issues.apache.org/jira/browse/HIVE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648846#action_12648846
]
Ashish Thusoo commented on HIVE-30:
-----------------------------------
cool contribution...
still going through the jsp code, but the following are some of the review
comments..
Inline Comments
hwi/build.xml:48 This should already be there in the classpath settings
in build-common.xml. Can you check on that and see whether you need another one?
hwi/src/java/org/apache/hadoop/hive/hwi/HWIServer.java:53 Can you look at
the code in HiveConf.java on how to deal with configurations. This mimics what
hadoop does with hadoop-default.xml and hadoop-site.xml. The confdir is then
simply setup by using --config like it is done for the rest of the hadoop.
Joydeep may be able to highlight this better as he set that up for hive.
hwi/src/java/org/apache/hadoop/hive/hwi/HWIServer.java:64 Same as the
previous comment.
hwi/src/java/org/apache/hadoop/hive/hwi/HWIServer.java:80 It is better to
use the HiveConf infrastructure here.
hwi/src/java/org/apache/hadoop/hive/hwi/HWIServer.java:147 javadocs
hwi/src/java/org/apache/hadoop/hive/hwi/HWIServer.java:151 javadocs
hwi/src/java/org/apache/hadoop/hive/hwi/HiveSessionManager.java:108 should
the command line arguments be stored away in the SessionManager instead of
reading it from the system properties all the time?
hwi/src/java/org/apache/hadoop/hive/hwi/HiveSessionManager.java:60 After
you come out of the goOn loop, it is probably good to cleanup any sessions that
may still be around or are we gauranteed that goOn will be set to false only
after all the threads have been cleaned up?
hwi/src/java/org/apache/hadoop/hive/hwi/SessionItem.java:32 Please remove
the author tag as indicated by the hadoop coding guidelines.
hwi/src/java/org/apache/hadoop/hive/hwi/SessionItem.java:55 javadocs for
these.
hwi/src/java/org/apache/hadoop/hive/hwi/SessionItem.java:91 I could not
find the stage1 and stage2 functions of the OpionsProcessor in this diff.
hwi/web/start_session_state.jsp:16 hello world.. does this need to go. I
presume this was put in for some testing?
> Hive web interface
> ------------------
>
> Key: HIVE-30
> URL: https://issues.apache.org/jira/browse/HIVE-30
> Project: Hadoop Hive
> Issue Type: Bug
> Reporter: Jeff Hammerbacher
> Priority: Minor
> Attachments: HIVE-30.patch
>
>
> Hive needs a web interface. The initial checkin should have:
> * simple schema browsing
> * query submission
> * query history (similar to MySQL's SHOW PROCESSLIST)
> A suggested feature: the ability to have a query notify the user when it's
> completed.
> Edward Capriolo has expressed some interest in driving this process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.