[
https://issues.apache.org/jira/browse/HIVE-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652188#action_12652188
]
Ashish Thusoo commented on HIVE-77:
-----------------------------------
Comments are inlined.
There are two major ones:
1. static LOG - we do that all over our code. Will that cause a problem or do
we have to clean that up in the same way that you have done for CliDriver and
SessionState.
2. This is the bigger one - I think we should just extend QTestUtil so that it
can run in a multi threaded mode instead of creating another class to run those
tests. We can then call QTestUtil in two modes and pass the list of tests that
want it to executed in the multi threaded mode. That would be more maintainable
in the long run.
Rest a few minor things like missing javadocs..
Inline Comments
ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java:687 Please add
javadocs for these.
ql/src/test/org/apache/hadoop/hive/ql/TestMTQueries.java:0 This file needs
javadocs.
ql/src/test/org/apache/hadoop/hive/ql/TestMTQueries.java:32 Can we pass the
names into this instead of hardcoding these in the code.
ql/src/test/org/apache/hadoop/hive/ql/TestMTQueries.java:0 Also instead of
a brand new test class, it is perhaps better to extend QTestUtil to run using
the Runner and then run it in two modes, concurrent and serial. We would be
able to avoid duplicate code and just have a single utility to test out both
the concurrent and serial tests.
ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java:202 Can we create a
similar array as source array for destination tables and destination files and
then loop over those arrays.
ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java:391 javadocs.
ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java:391 Where is this
function called from?
build-common.xml:226 why are we excluding TestMTQueries here?
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:62 Would static
log not work. If so, we have that all over the code and just fixing it here
will not work.
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java:265
javadocs for these.
> thread safe query execution
> ---------------------------
>
> Key: HIVE-77
> URL: https://issues.apache.org/jira/browse/HIVE-77
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Reporter: Joydeep Sen Sarma
> Assignee: Joydeep Sen Sarma
> Attachments: hive-77.patch.1
>
>
> this came up in hive-30 where there's a multithreaded hive server in the
> works. at the minimum, the sessionstate objects should be thread local
> singletons. but filing a more general bug that can cover this issue + code
> audit for any other static variables + test suite for running queries from a
> multi-threaded environment
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
