[ 
https://issues.apache.org/jira/browse/HIVE-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681134#action_12681134
 ] 

Zheng Shao commented on HIVE-337:
---------------------------------

It's true that LazySimpleSerDe does not share code with 
MetadataTypedColumnsetSerDe or DynamicSerDe, but the reason of that is because 
the design principle is completely different and there is no shared code at all.

@Raghu: I thought you were saying automatically detect the format based on data 
(not metadata). If we can rely on metadata, then we are on the same track.

@Namit: The current goal of LazySimpleSerDe is to replace 
MetaDataTypedColumnsetSerDe and TCTLSeparatedProtocol. LazySerDe is a thin 
class on top of a lot of utility classes that can be reused for any 
lazily-initialized serdes.


I think overall we are on agreement:
1. We should reuse code as much as possible.
2. We should rely on metadata to find out the serialization format difference 
(instead of automatically figure it out from the data).

The difference between parametering a class and 2 classes are so small - I can 
write a wrapper to wrap 2 classes. This is a minor issue.
This is different from reusing the code, because most of the code are in 
utility classes that will be reused.

At this point, the goal is only to support what is already supported (by 
Meta../TCTL...). For new features, let's keep the discussion on a separate jira.


> LazySimpleSerDe should support array and map types
> --------------------------------------------------
>
>                 Key: HIVE-337
>                 URL: https://issues.apache.org/jira/browse/HIVE-337
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>            Priority: Blocker
>
> Once we do that, we can completely deprecate 
> DynamicSerDe/TCTLSeparatedProtocol, and close any bugs that 
> DynamicSerDe/TCTLSeparatedProtocol has.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to