[
https://issues.apache.org/jira/browse/HIVE-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693664#action_12693664
]
Zheng Shao commented on HIVE-352:
---------------------------------
Haven't looked it completely through yet.
Some initial comments:
BytesRefWritable.java: You might want to replace all BytesWritable to
BytesRefWritable.
86: I don't understand why equal() can be implemented like this.
ColumnarSerDe.java: You might want to refactor LazySimpleSerDe to extract out
the common functionality, (and reuse them in ColumnarSerDe), instead of
inheriting from LazySimpleSerDe. This will give you much better control - the
current implementation won't work unless you also override initialize(),
serialize() - basically all methods from LazySimpleSerDe.
If you would like to refactor LazySimpleSerDe to extract out the common
functionality for ColumnarSerDe, make sure you follow HIVE-375.
Since HIVE-375 is not committed yet, you might want to work on HIVE-360 first.
> Make Hive support column based storage
> --------------------------------------
>
> Key: HIVE-352
> URL: https://issues.apache.org/jira/browse/HIVE-352
> Project: Hadoop Hive
> Issue Type: New Feature
> Reporter: He Yongqiang
> Attachments: HIve-352-draft-2009-03-28.patch
>
>
> column based storage has been proven a better storage layout for OLAP.
> Hive does a great job on raw row oriented storage. In this issue, we will
> enhance hive to support column based storage.
> Acctually we have done some work on column based storage on top of hdfs, i
> think it will need some review and refactoring to port it to Hive.
> Any thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
