[
https://issues.apache.org/jira/browse/HIVE-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719901#action_12719901
]
Zheng Shao commented on HIVE-521:
---------------------------------
@HIVE-521-all-v3.patch:
Some nitpicks about error messages:
"The function IF(expr1,expr2,expr3) only accepts 3 arguments" --> "The function
IF(expr1,expr2,expr3) accepts exactly 3 arguments"
"The first expression of function IF is expected to" --> "The first argument of
function IF should be "
"The second and the third expressions of function IF should have the same type"
--> "The second and the third arguments of function IF should have the same
type"
"but it's found the former is \"" + arguments[1].getTypeName() + "\", while
the latter is \"" + arguments[2].getTypeName() + "\""); --> "but they are
different: \"" + arguments[1].getTypeName() + "\" and \"" +
arguments[2].getTypeName() + "\"");
Please also do an "svn up" since there are some recent changes that might break
this patch. Also try "ant test -Dhadoop.version=0.17.0 -Doverwrite=true" to get
all changed test outputs (if any).
> Move size, if, isnull, isnotnull to GenericUDF
> ----------------------------------------------
>
> Key: HIVE-521
> URL: https://issues.apache.org/jira/browse/HIVE-521
> Project: Hadoop Hive
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Zheng Shao
> Assignee: Min Zhou
> Fix For: 0.4.0
>
> Attachments: HIVE-521-all-v1.patch, HIVE-521-all-v2.patch,
> HIVE-521-all-v3.patch, HIVE-521-IF-2.patch, HIVE-521-IF-3.patch,
> HIVE-521-IF-4.patch, HIVE-521-IF-5.patch, HIVE-521-IF.patch
>
>
> See HIVE-511 for an example of the move.
> size, if, isnull, isnotnull are all implemented with UDF but they are
> actually working on variable types of objects. We should move them to
> GenericUDF for better type handling.
> This also helps to clean up the hack in doing type matching/type conversion
> in UDF.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.