[
https://issues.apache.org/jira/browse/HIVE-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721232#action_12721232
]
Zheng Shao commented on HIVE-521:
---------------------------------
Yes, the 2nd approach is more concise. But I think the 1st approach is more
elegant.
Doing string comparisons are kind of ugly and sometimes error-prone, because
strings are usually for display purposes.
> Move size, if, isnull, isnotnull to GenericUDF
> ----------------------------------------------
>
> Key: HIVE-521
> URL: https://issues.apache.org/jira/browse/HIVE-521
> Project: Hadoop Hive
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Zheng Shao
> Assignee: Min Zhou
> Fix For: 0.4.0
>
> Attachments: HIVE-521-all-v1.patch, HIVE-521-all-v2.patch,
> HIVE-521-all-v3.patch, HIVE-521-all-v4.patch, HIVE-521-all-v5.patch,
> HIVE-521-all-v6.patch, HIVE-521-all-v7.patch, HIVE-521-IF-2.patch,
> HIVE-521-IF-3.patch, HIVE-521-IF-4.patch, HIVE-521-IF-5.patch,
> HIVE-521-IF.patch
>
>
> See HIVE-511 for an example of the move.
> size, if, isnull, isnotnull are all implemented with UDF but they are
> actually working on variable types of objects. We should move them to
> GenericUDF for better type handling.
> This also helps to clean up the hack in doing type matching/type conversion
> in UDF.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.