[ 
https://issues.apache.org/jira/browse/HIVE-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748995#action_12748995
 ] 

Edward Capriolo commented on HIVE-752:
--------------------------------------

All, 

I am a little perturbed about this. If I am looking at this correctly this is 
the first and only revision of ShimLoader in SVN.

http://svn.apache.org/viewvc/hadoop/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/ShimLoader.java?view=log

As Venkat points out this Jetty Shims are completely broken. Which the class 
names specified 
{noformat}
org.apache.jetty.hive.shims.Jetty19Shims
{noformat}
incorrectly, I believe any attempt to start up HWI with any version of Hadoop 
would have failed. I have fixed the class name for 20shim and that is failing 
now with a null pointer.

Why did we commit shims without any test cases? 

I know HWI can be somewhat awkward to test case, but was it tested at all?

> Encountered ClassNotFound exception when trying HWI server
> ----------------------------------------------------------
>
>                 Key: HIVE-752
>                 URL: https://issues.apache.org/jira/browse/HIVE-752
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Clients
>         Environment: Hadoop 0.18.3
>            Reporter: Venkat Ramachandran
>            Assignee: Edward Capriolo
>
> Encountered ClassNotFound exception (for class: 
> org.apache.jetty.hive.shims.Jetty18Shims) when trying to start HWI server on 
> Hadoop 18.
> It appears that the class ShimLoader 
> (org.apache.hadoop.hive.shims.ShimLoader) is referring to incorrect classes 
> as below:
> static {
>     JETTY_SHIM_CLASSES.put("0.17", 
> "org.apache.jetty.hive.shims.Jetty17Shims");
>     JETTY_SHIM_CLASSES.put("0.18", 
> "org.apache.jetty.hive.shims.Jetty18Shims");
>     JETTY_SHIM_CLASSES.put("0.19", 
> "org.apache.jetty.hive.shims.Jetty19Shims");
>     JETTY_SHIM_CLASSES.put("0.20", 
> "org.apache.jetty.hive.shims.Jetty20Shims");
>   }
> however, I think it should be as below:
>  static 
>   {
>         JETTY_SHIM_CLASSES.put("0.17", 
> "org.apache.hadoop.hive.shims.Jetty17Shims");
>         JETTY_SHIM_CLASSES.put("0.18", 
> "org.apache.hadoop.hive.shims.Jetty18Shims");
>         JETTY_SHIM_CLASSES.put("0.19", 
> "org.apache.hadoop.hive.shims.Jetty19Shims");
>         JETTY_SHIM_CLASSES.put("0.20", 
> "org.apache.hadoop.hive.shims.Jetty20Shims");
>   } 
> Wondering if anybody else encountered this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to