[ 
https://issues.apache.org/jira/browse/HIVE-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804632#action_12804632
 ] 

Ning Zhang commented on HIVE-1088:
----------------------------------

Yongqiang, I noticed you have added a unit test in TestRCFile.java. Is it 
possible to add a unit test as .q file? The benefit of doing this is that 
TestRCFile just test one code path for particular functions. If we change the 
code path later in the real execution engine, we may not cover the error case, 
but a .q file will  be more likely to catch the caes.

> RCFile RecordReader's first split will read duplicate rows if the split end 
> is < the first SYNC mark
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-1088
>                 URL: https://issues.apache.org/jira/browse/HIVE-1088
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: He Yongqiang
>            Assignee: He Yongqiang
>             Fix For: 0.5.0, 0.6.0
>
>         Attachments: hive-rcfile-reader-branch-0.5.patch, 
> hive-rcfile-reader-trunk.2.patch, hive-rcfile-reader-trunk.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to