[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829409#action_12829409
]
Zheng Shao commented on HIVE-1123:
----------------------------------
The sticking point is that the patch is too big, and there is not a short list
of rules for your changes.
I agree conforming to checkstyle in general is a good thing to do but there
might be small rules here and there that we might not want to follow. Examples
include the indentation rule (which you also mentioned personally you like the
4-space approach). There might be more but it's hard for me to catch them all.
If you can give me a full list of the rules of the changes you made, it will
also speed up the review/commits.
I would ask other guys on the team to take a look at these patches. If we can
get a consensus we will commit them soon.
In the future, it would also be great if you can make these patches one by one
to save the effort of (potentially) redoing some of them because of conflicts.
Once we agree on the rules of the changes, it should be very fast to
review/commit the other patches.
Does that sound good?
> Checkstyle fixes
> ----------------
>
> Key: HIVE-1123
> URL: https://issues.apache.org/jira/browse/HIVE-1123
> Project: Hadoop Hive
> Issue Type: Task
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1123.checkstyle.patch, HIVE-1123.cli.2.patch,
> HIVE-1123.cli.patch, HIVE-1123.common.2.patch, HIVE-1123.common.patch,
> HIVE-1123.contrib.2.patch, HIVE-1123.contrib.patch, HIVE-1123.hwi.2.patch,
> HIVE-1123.hwi.patch, HIVE-1123.jdbc.2.patch, HIVE-1123.jdbc.patch,
> HIVE-1123.metastore.2.patch, HIVE-1123.metastore.patch, HIVE-1123.ql.2.patch,
> HIVE-1123.ql.patch, HIVE-1123.serde.2.patch, HIVE-1123.serde.patch,
> HIVE-1123.service.2.patch, HIVE-1123.service.patch, HIVE-1123.shims.2.patch,
> HIVE-1123.shims.patch
>
>
> Fix checkstyle errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
