[ 
https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829757#action_12829757
 ] 

John Sichi commented on HIVE-1129:
----------------------------------

In the spirit of keeping patch transactions small and focused, maybe it would 
be better to commit this patch as is and assign me a separate JIRA for adding 
and using the setter methods?  The reason I say this is that my patch followed 
the existing pattern here in the same file:

    if(work.getMinSplitSize() != null) {
      job.setInt(HiveConf.ConfVars.MAPREDMINSPLITSIZE.varname, 
         work.getMinSplitSize().intValue());
    }

So that code will need to be changed too as part of consistently using the new 
setters, and that change is unrelated to my fix for the existing bug with 
assertions.


> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1129.1.patch
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was 
> causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the 
> following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to