[ 
https://issues.apache.org/jira/browse/HIVE-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835952#action_12835952
 ] 

Ning Zhang commented on HIVE-1182:
----------------------------------

template file changes look fine. but I'm sure about the changes to 
SessionState.start(session). This function now returns the old session and 
previously it returns the new session. It is called in other places as well. 
Can you make sure that this change of semantics doesn't break our design and 
other use cases? If what we need here is to be able to get the current session 
and close it, we can do it without changing the semantics of 
SessionState.start(session). 

> Fix TestCliDriver too many open file error
> ------------------------------------------
>
>                 Key: HIVE-1182
>                 URL: https://issues.apache.org/jira/browse/HIVE-1182
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.4.1, 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>            Priority: Critical
>             Fix For: 0.4.2, 0.5.0, 0.6.0
>
>         Attachments: HIVE-1182.1.branch-0.4.patch, 
> HIVE-1182.1.branch-0.5.patch, HIVE-1182.1.patch
>
>
> There is a bug in TestCliDriver that loads all .q files for each of the .q 
> test.
> We only need to load the .q file for that particular .q test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to