[ 
https://issues.apache.org/jira/browse/HIVE-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839574#action_12839574
 ] 

Namit Jain commented on HIVE-1197:
----------------------------------

Overall, looks good - some general comments.

Would it be a good idea to make BucketizedHiveInputFormat extend 
HiveInpuFormat, and BucketizedHiveRecordReader extend HiveRecordReader ?
You wont have to copy a lot of code, and it would be easy to maintain. For 
example, the check for ExecMapper in hiverecordreader and such future 
optimizations would be easier to maintain.

> create a new input format where a mapper spans a file
> -----------------------------------------------------
>
>                 Key: HIVE-1197
>                 URL: https://issues.apache.org/jira/browse/HIVE-1197
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Siying Dong
>             Fix For: 0.6.0
>
>         Attachments: hive.1197.1.patch
>
>
> This will be needed for Sort merge joins.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to