[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873236#action_12873236 ]
Ning Zhang commented on HIVE-1198: ---------------------------------- The new patch looks good. I will commit after the tests pass. > When checkstyle is activated for Hive in Eclipse environment, it shows all > checkstyle problems as errors. > --------------------------------------------------------------------------------------------------------- > > Key: HIVE-1198 > URL: https://issues.apache.org/jira/browse/HIVE-1198 > Project: Hadoop Hive > Issue Type: Improvement > Components: Build Infrastructure > Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin > 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010) > Reporter: Arvind Prabhakar > Assignee: Arvind Prabhakar > Priority: Minor > Attachments: HIVE-1198-1.patch, HIVE-1198-2.patch, HIVE-1198.patch > > > As of now, checkstyle plugin reports all problems as errors. This causes an > overwhelming number of errors to show up (3000+) which masks real errors that > might be there. Since all the checkstyle violations are not going to be fixed > in one shot, it is desirable to lower the severity of checkstyle violations > to warnings so that the plugin can be kept enabled. This will encourage > developers to spot checkstyle violations in the files they touch and > potentially fix them as they go along, along with pointing out violations as > they code. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.