[ https://issues.apache.org/jira/browse/HIVE-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879986#action_12879986 ]
HBase Review Board commented on HIVE-1412: ------------------------------------------ Message from: "Carl Steinbach" <c...@cloudera.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/206/ ----------------------------------------------------------- Review request for Hive Developers. Summary ------- Review for https://issues.apache.org/jira/secure/attachment/12447377/HIVE-1412.patch This addresses bug HIVE-1412. http://issues.apache.org/jira/browse/HIVE-1412 Diffs ----- trunk/ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java 955674 Diff: http://review.hbase.org/r/206/diff Testing ------- Thanks, Carl > CombineHiveInputFormat bug on tablesample > ----------------------------------------- > > Key: HIVE-1412 > URL: https://issues.apache.org/jira/browse/HIVE-1412 > Project: Hadoop Hive > Issue Type: Bug > Components: Query Processor > Reporter: Ning Zhang > Assignee: Ning Zhang > Fix For: 0.6.0 > > Attachments: HIVE-1412.patch > > > CombineHiveInputFormat should combine all files inside one partition to form > a split but should not takes files cross partition boundary. This works for > regular table and partitions since all input paths are directory. However > this breaks when the input is files (in which case tablesample could be the > use case). CombineHiveInputFormat should adjust to the case when input could > also be non-directories. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.