[
https://issues.apache.org/jira/browse/HIVE-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880992#action_12880992
]
John Sichi commented on HIVE-1414:
----------------------------------
OK, those choices make sense.
Some review comments:
1) In HIVE-1405, I added a processFile method which takes care of closing the
reader to avoid resource leak. Could you review and commit that patch, and
then update your patch here to call processFile?
2) If either getenv or getProperty returns null, we should skip the
corresponding exists check completely to avoid looking for a filename like
("null/bin/.hiverc")
3) I think your code needs to move up into my processInitFiles location,
otherwise it won't get run for the -f and -e cases. Also, let's say that if -i
is specified, then we skip the .hiverc execution (to match bash -init-file
behavior). Note that .hiverc execution should happen inside of my silent-mode
block so that it does not show up in console output.
> automatically invoke .hiverc init script
> ----------------------------------------
>
> Key: HIVE-1414
> URL: https://issues.apache.org/jira/browse/HIVE-1414
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Clients
> Affects Versions: 0.5.0
> Reporter: John Sichi
> Assignee: Edward Capriolo
> Attachments: hive-1414-patch-1.txt
>
>
> Similar to .bashrc but run Hive SQL commands.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
