[ 
https://issues.apache.org/jira/browse/HIVE-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881426#action_12881426
 ] 

HBase Review Board commented on HIVE-1416:
------------------------------------------

Message from: "John Sichi" <jsi...@facebook.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/223/#review268
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
<http://review.hbase.org/r/223/#comment1126>

    Rather than repeating the HiveConf.getVar in several places, it would be 
cleaner to just pass the configuration down into the Utilities method as the 
new parameter and have it do the configuration check.



http://svn.apache.org/repos/asf/hadoop/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java
<http://review.hbase.org/r/223/#comment1124>

    This "anObject" insertion looks like it was accidental.


- John





> Dynamic partition inserts left empty files uncleaned in hadoop 0.17 local mode
> ------------------------------------------------------------------------------
>
>                 Key: HIVE-1416
>                 URL: https://issues.apache.org/jira/browse/HIVE-1416
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ning Zhang
>            Assignee: Ning Zhang
>             Fix For: 0.6.0, 0.7.0
>
>         Attachments: HIVE-1416.patch
>
>
> Hive parses the file name generated by tasks to figure out the task ID in 
> order to generate files for empty buckets. Different hadoop versions and 
> execution mode have different ways of naming  output files by 
> mappers/reducers. We need to move the parsing code to shims. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to