-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/275/
-----------------------------------------------------------
(Updated 2010-07-06 19:24:53.267440)
Review request for Hive Developers and John Sichi.
Changes
-------
Updated 'Bugs' field in review request.
Summary
-------
This is the patch revision 5 for HIVE-287. Please see the Jira comments for
full description.
This addresses bug HIVE-287.
http://issues.apache.org/jira/browse/HIVE-287
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 4109103
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 7e6e63e
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 252b89d
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDAFResolver.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java
0ef4734
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBridge.java
916eb33
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCount.java
0054664
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFHistogramNumeric.java
8d22ef1
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMax.java 6785687
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMin.java 051f3a1
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFParameterInfo.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFResolver.java
9888b52
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFResolver2.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java ce97afd
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVariance.java
26dc84c
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/SimpleGenericUDAFParameterInfo.java
PRE-CREATION
ql/src/test/queries/clientnegative/invalid_avg_syntax.q PRE-CREATION
ql/src/test/queries/clientnegative/invalid_max_syntax.q PRE-CREATION
ql/src/test/queries/clientnegative/invalid_min_syntax.q PRE-CREATION
ql/src/test/queries/clientnegative/invalid_std_syntax.q PRE-CREATION
ql/src/test/queries/clientnegative/invalid_stddev_samp_syntax.q PRE-CREATION
ql/src/test/queries/clientnegative/invalid_sum_syntax.q PRE-CREATION
ql/src/test/queries/clientnegative/invalid_var_samp_syntax.q PRE-CREATION
ql/src/test/queries/clientnegative/invalid_variance_syntax.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_count.q 2d1510f
ql/src/test/results/clientnegative/invalid_avg_syntax.q.out PRE-CREATION
ql/src/test/results/clientnegative/invalid_max_syntax.q.out PRE-CREATION
ql/src/test/results/clientnegative/invalid_min_syntax.q.out PRE-CREATION
ql/src/test/results/clientnegative/invalid_std_syntax.q.out PRE-CREATION
ql/src/test/results/clientnegative/invalid_stddev_samp_syntax.q.out
PRE-CREATION
ql/src/test/results/clientnegative/invalid_sum_syntax.q.out PRE-CREATION
ql/src/test/results/clientnegative/invalid_var_samp_syntax.q.out PRE-CREATION
ql/src/test/results/clientnegative/invalid_variance_syntax.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_count.q.out 2adffd8
Diff: http://review.hbase.org/r/275/diff
Testing
-------
Ran all tests on trunk.
Thanks,
Arvind