[ https://issues.apache.org/jira/browse/HIVE-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886918#action_12886918 ]
HBase Review Board commented on HIVE-1096: ------------------------------------------ Message from: "Carl Steinbach" <c...@cloudera.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/229/ ----------------------------------------------------------- (Updated 2010-07-09 15:10:54.970189) Review request for Hive Developers. Changes ------- Updated the diff with http://issues.apache.org/jira/secure/attachment/12449054/hive-1096-12.patch.txt Summary ------- Hive Variables This addresses bug HIVE-1096. http://issues.apache.org/jira/browse/HIVE-1096 Diffs (updated) ----- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 955109 trunk/conf/hive-default.xml 955109 trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 955109 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/VariableSubstitution.java PRE-CREATION trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/AddResourceProcessor.java 955109 trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/DeleteResourceProcessor.java 955109 trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java 955109 trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 955109 trunk/ql/src/test/queries/clientpositive/set_processor_namespaces.q PRE-CREATION trunk/ql/src/test/results/clientpositive/set_processor_namespaces.q.out PRE-CREATION Diff: http://review.hbase.org/r/229/diff Testing ------- Thanks, Edward > Hive Variables > -------------- > > Key: HIVE-1096 > URL: https://issues.apache.org/jira/browse/HIVE-1096 > Project: Hadoop Hive > Issue Type: New Feature > Components: Query Processor > Reporter: Edward Capriolo > Assignee: Edward Capriolo > Fix For: 0.6.0, 0.7.0 > > Attachments: 1096-9.diff, hive-1096-10-patch.txt, > hive-1096-11-patch.txt, hive-1096-12.patch.txt, hive-1096-2.diff, > hive-1096-7.diff, hive-1096-8.diff, hive-1096.diff > > > From mailing list: > --Amazon Elastic MapReduce version of Hive seems to have a nice feature > called "Variables." Basically you can define a variable via command-line > while invoking hive with -d DT=2009-12-09 and then refer to the variable via > ${DT} within the hive queries. This could be extremely useful. I can't seem > to find this feature even on trunk. Is this feature currently anywhere in the > roadmap?-- > This could be implemented in many places. > A simple place to put this is > in Driver.compile or Driver.run we can do string substitutions at that level, > and further downstream need not be effected. > There could be some benefits to doing this further downstream, parser,plan. > but based on the simple needs we may not need to overthink this. > I will get started on implementing in compile unless someone wants to discuss > this more. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.