[ 
https://issues.apache.org/jira/browse/HIVE-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888086#action_12888086
 ] 

Ning Zhang commented on HIVE-1462:
----------------------------------

looks good in general, some nitpicks: 
 - lines 633, 666, updateProgress() was called after commit() and 
closeWriters(), but it was already been called inside these 2 functions. Should 
we just remove these 2 lines for simplicity, as well as consistent with the 
case for abortWriters() in line 644. 

> Reporting progress in FileSinkOperator works in multiple directory case
> -----------------------------------------------------------------------
>
>                 Key: HIVE-1462
>                 URL: https://issues.apache.org/jira/browse/HIVE-1462
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: Siying Dong
>            Assignee: Siying Dong
>         Attachments: HIVE-1462.1.patch
>
>
> HIVE-1403 fixes the issue of timing out issue when closing too many files but 
> it doesn't cover the case that files are under different directories. For the 
> case of dynamic partitioning, it is usually the case so that we still get 
> time-out.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to