[
https://issues.apache.org/jira/browse/HIVE-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890446#action_12890446
]
Bennie Schut commented on HIVE-1126:
------------------------------------
Hi John,
Thanks for the speedy comments.
I'll make the fixes tomorrow morning.
* Apache file header. I'll add them
* Expanded imports. ok.
* synchronizedon getTables. I forgot about that. When SQuirreL is rebuilding
the tables tree a few times really fast (most likely concurrently) it seems to
end up with the same table name multiple times in the list. I had a hunch this
was related to the client not being completely thread safe (or the way I use it
anyway). After making it synchronized I never saw this problem again. I'll also
look into this a little more. On the "DatabaseMetaData getMetaData()" we could
also decide to create a new client object which would probably also prevent
this.
* supportsNamedParameters sorry I confused it for something else. I'll revert
that one.
In most cases I ran a little test on the mysql jdbc driver to know what they
returned and used that as a baseline.
> Missing some Jdbc functionality like getTables getColumns and
> HiveResultSet.get* methods based on column name.
> --------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1126
> URL: https://issues.apache.org/jira/browse/HIVE-1126
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Clients
> Affects Versions: 0.7.0
> Reporter: Bennie Schut
> Assignee: Bennie Schut
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: HIVE-1126-1.patch, HIVE-1126-2.patch, HIVE-1126.patch,
> HIVE-1126_patch(0.5.0_source).patch
>
>
> I've been using the hive jdbc driver more and more and was missing some
> functionality which I added
> HiveDatabaseMetaData.getTables
> Using "show tables" to get the info from hive.
> HiveDatabaseMetaData.getColumns
> Using "describe tablename" to get the columns.
> This makes using something like SQuirreL a lot nicer since you have the list
> of tables and just click on the content tab to see what's in the table.
> I also implemented
> HiveResultSet.getObject(String columnName) so you call most get* methods
> based on the column name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
