[ https://issues.apache.org/jira/browse/HIVE-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897464#action_12897464 ]
John Sichi commented on HIVE-1495: ---------------------------------- * Can you add Javadoc text for the new inputs/outputs @params to HiveIndexHandler.generateIndexBuildTaskList (and move them below )? It's important for interface methods to be documented as precisely as possible. * You are missing the non-partitioned case (see the output for the example I gave above in index_compact_1.q.out, which is still missing input/output). * I think driver.compile should already be constructing read/write entities for the reentrant INSERT. You can access them as driver.getQueryPlan().getInputs/Outputs() and copy them into the sets passed in by the caller (rather than constructing new ones explicitly). This would be more robust. > supply correct information to hooks and lineage for index rebuild > ----------------------------------------------------------------- > > Key: HIVE-1495 > URL: https://issues.apache.org/jira/browse/HIVE-1495 > Project: Hadoop Hive > Issue Type: Improvement > Components: Indexing > Affects Versions: 0.7.0 > Reporter: John Sichi > Assignee: He Yongqiang > Fix For: 0.7.0 > > Attachments: hive-1495.1.patch, hive-1495.2.patch > > > This is a followup for HIVE-417. > Ashish can probably help on how this should work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.