> On 2010-08-11 06:57:04, namit jain wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g, line 572 > > <http://review.cloudera.org/r/508/diff/2/?file=5203#file5203line572> > > > > remove KW_SCHEMAS
In MySQL SHOW SCHEMAS is a synonym for SHOW DATABASES as of version 5.0.2. I think the general convention in Hive is to mimic the behavior of MySQL. Please let me know if there is a reason why we should not do that here. http://dev.mysql.com/doc/refman/5.0/en/show-databases.html - Carl ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/508/#review838 ----------------------------------------------------------- On 2010-08-04 15:34:31, Carl Steinbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/508/ > ----------------------------------------------------------- > > (Updated 2010-08-04 15:34:31) > > > Review request for Hive Developers. > > > Summary > ------- > > Database/Scheme support for Hive. > > * Implemented 'SHOW DATABASES' command > * Refactored TestHiveMetaStore and enabled tests for remote metastore client. > * Added launch configurations for TestHiveMetaStore and > TestHiveMetaStoreRemote > > > This addresses bug HIVE-675. > http://issues.apache.org/jira/browse/HIVE-675 > > > Diffs > ----- > > build-common.xml d4ff895 > eclipse-templates/TestHive.launchtemplate 24efc12 > eclipse-templates/TestHiveMetaStore.launchtemplate PRE-CREATION > eclipse-templates/TestHiveMetaStoreRemote.launchtemplate PRE-CREATION > metastore/if/hive_metastore.thrift 478d0af > metastore/src/gen-cpp/ThriftHiveMetastore.h e2538fb > metastore/src/gen-cpp/ThriftHiveMetastore.cpp f945a3a > metastore/src/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp ed2bb99 > metastore/src/gen-cpp/hive_metastore_types.h 1b0c706 > metastore/src/gen-cpp/hive_metastore_types.cpp b5a403d > > metastore/src/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java > 78c78d9 > > metastore/src/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java > 25408d9 > metastore/src/gen-php/ThriftHiveMetastore.php ea4add5 > metastore/src/gen-php/hive_metastore_types.php 61872a0 > metastore/src/gen-py/hive_metastore/ThriftHiveMetastore-remote fc06cba > metastore/src/gen-py/hive_metastore/ThriftHiveMetastore.py 4a0bc67 > metastore/src/gen-py/hive_metastore/ttypes.py ea7269e > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 39dbd52 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 4fb296a > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > c6541af > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 6013644 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 0818689 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > a06384c > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 4951bd6 > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 4488f94 > metastore/src/model/org/apache/hadoop/hive/metastore/model/MDatabase.java > b3e098d > metastore/src/model/package.jdo 206ba75 > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > fff6aad > > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreBase.java > PRE-CREATION > > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreRemote.java > bc950b9 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java bc268a4 > ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java d59f48c > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 04dd9e3 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 2ecda01 > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > eedf9e3 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 0484c91 > ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 02bf926 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 70cd05f > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java > eb079aa > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateDatabaseDesc.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java ed4ed22 > ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/ShowDatabasesDesc.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/SwitchDatabaseDesc.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java b4651a2 > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java ab39ca4 > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java > 26cc71a > ql/src/test/queries/clientnegative/create_database_bad_name.q PRE-CREATION > ql/src/test/queries/clientnegative/database_switch_test.q PRE-CREATION > ql/src/test/queries/clientpositive/database.q PRE-CREATION > ql/src/test/results/clientnegative/create_database_bad_name.q.out > PRE-CREATION > ql/src/test/results/clientnegative/database_switch_test.q.out PRE-CREATION > ql/src/test/results/clientpositive/database.q.out PRE-CREATION > > Diff: http://review.cloudera.org/r/508/diff > > > Testing > ------- > > > Thanks, > > Carl > >
