[
https://issues.apache.org/jira/browse/HIVE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902102#action_12902102
]
John Sichi commented on HIVE-1536:
----------------------------------
Thanks Sean. I have two more items and then I think this one is ready for
commit.
* for the column name length, we should use 128, since that's the length
declared for MFieldSchema.FNAME in metastore/src/model/package.jdo
* for PreparedStatement.execute, you can get rid of the TODO comment; the
behavior is correct as is (the true/false return only discriminates between a
query with a cursor vs DDL/DML; it's not related to whether any rows are
actually returned by the query)
> Add support for JDBC PreparedStatements
> ---------------------------------------
>
> Key: HIVE-1536
> URL: https://issues.apache.org/jira/browse/HIVE-1536
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Drivers
> Affects Versions: 0.6.0
> Reporter: Sean Flatley
> Assignee: Sean Flatley
> Fix For: 0.7.0
>
> Attachments: all-tests-ant.log, HIVE-1536-2.patch,
> HIVE-1536-changes-2.txt, HIVE-1536-changes.txt, HIVE-1536.patch,
> JdbcDriverTest-ant-2.log, JdbcDriverTest-ant.log
>
>
> As a result of a Sprint which had us using Pentaho Data Integration with the
> Hive database we have updated the driver. Many PreparedStatement methods
> have been implemented. A patch will be attached tomorrow with a summary of
> changes.
> Note: A checkout of Hive/trunk was performed and the TestJdbcDriver test
> cased was run. This was done before any modifications were made to the
> checked out project. The testResultSetMetaData failed:
> java.sql.SQLException: Query returned non-zero code: 9, cause: FAILED:
> Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.MapRedTask
> at
> org.apache.hadoop.hive.jdbc.HiveStatement.executeQuery(HiveStatement.java:189)
> at
> org.apache.hadoop.hive.jdbc.TestJdbcDriver.testResultSetMetaData(TestJdbcDriver.java:530)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at junit.framework.TestCase.runTest(TestCase.java:154)
> at junit.framework.TestCase.runBare(TestCase.java:127)
> at junit.framework.TestResult$1.protect(TestResult.java:106)
> at junit.framework.TestResult.runProtected(TestResult.java:124)
> at junit.framework.TestResult.run(TestResult.java:109)
> at junit.framework.TestCase.run(TestCase.java:118)
> at junit.framework.TestSuite.runTest(TestSuite.java:208)
> at junit.framework.TestSuite.run(TestSuite.java:203)
> at
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:420)
> at
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:911)
> at
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:768)
> A co-worker did the same and the tests passed. Both environments were Ubuntu
> and Hadoop version 0.20.2.
> Tests added to the TestJdbcDriver by us were successful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
