[
https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905655#action_12905655
]
John Sichi commented on HIVE-1546:
----------------------------------
@Carl: I understand your concern, but this seemed like the least intrusive
approach as opposed to continually patching Hive to refine what Howl's CLI
wants to support at a given point in time (which really has nothing to do with
Hive). The override approach allows that behavior to be factored completely
out into Howl. A number of our existing extensibility interfaces (e.g.
StorageHandler) already have similar issues regarding impact from continual
refactoring, so I expect an across-the-board SPI stabilization effort to be
required in the future (with corresponding migrations from old to new). This
will need to be part of that effort.
@Ashutosh: I hit the hang you mentioned, so I can retry tests with your latest
patch. But let's resolve the approach with Carl first. In particular, can we
get agreement from the Howl team that even though we're introducing this
dependency now, we will not let its existence hinder future semantic analyzer
refactoring within Hive? As long as we all stay in frequent communication, we
can make that work.
@Both: one possible refinement would be to limit the public interface to just
validation (as opposed to full semantic analysis). In that case, we would have
HiveStmtValidatorFactory producing HiveStmtValidator with just a single method
validate(). This would also remove the unpleasantness of having a factory
returning a base class rather than an interface. However, if CLI is going to
need to do more than just validation, then this isn't good enough.
> Ability to plug custom Semantic Analyzers for Hive Grammar
> ----------------------------------------------------------
>
> Key: HIVE-1546
> URL: https://issues.apache.org/jira/browse/HIVE-1546
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Metastore
> Affects Versions: 0.7.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.7.0
>
> Attachments: hive-1546-3.patch, hive-1546-4.patch, hive-1546.patch,
> hive-1546_2.patch
>
>
> It will be useful if Semantic Analysis phase is made pluggable such that
> other projects can do custom analysis of hive queries before doing metastore
> operations on them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
